Skip to content

EventFiringWebElement support for ElementFinder #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020
Merged

EventFiringWebElement support for ElementFinder #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions atest/acceptance/2-event_firing_webdriver/event_firing_webdriver.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@ Event Firing Webdriver Input Text (WebElement)
... LOG 1:14 INFO After clear and send_keys
Input Text //input[@name="textfield"] FooBar

Event Firing Webdriver Click Element (WebElement)
Event Firing Webdriver With Get WebElement (WebElement)
[Tags] NoGrid
[Documentation]
... LOG 1:5 INFO Before click
... LOG 1:9 INFO After click
Click Element //input[@name="ok_button"]
Go To ${ROOT}/nested_divs.html
${link}= Get WebElement //a[@id="needleC"]
Wait Until Element Contains ${link} top/c/needle
3 changes: 2 additions & 1 deletion src/SeleniumLibrary/locators/elementfinder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from robot.api import logger
from robot.utils import NormalizedDict
from selenium.webdriver.remote.webelement import WebElement
from selenium.webdriver.support.event_firing_webdriver import EventFiringWebElement

from SeleniumLibrary.base import ContextAware
from SeleniumLibrary.errors import ElementNotFound
Expand Down Expand Up @@ -102,7 +103,7 @@ def unregister(self, strategy_name):

def _is_webelement(self, element):
# Hook for unit tests
return isinstance(element, WebElement)
return isinstance(element, (WebElement, EventFiringWebElement))

def _disallow_webelement_parent(self, element):
if self._is_webelement(element):
Expand Down