Fix security vulnerabilities in work queue, MCP server, and hooks#68
Merged
Fix security vulnerabilities in work queue, MCP server, and hooks#68
Conversation
chore: Release v3.8.0
Release v3.9.0 - Global Memory
- Add ALLOWED_UPDATE_COLUMNS allowlist in work_queue.py to validate column names before SQL interpolation in update_work() - Add -- end-of-options separator and file_pattern regex validation in MCP _search_codebase() to prevent grep flag injection - Apply shlex.quote() to task fields in HookExecutor before shell command format substitution to prevent shell injection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkQueue.update_work()to prevent SQL injection via dynamic column names--end-of-options separator and file_pattern validation in MCP_search_codebaseto prevent grep flag injectionshlex.quote()to all task field substitutions inHookExecutorto prevent shell injection via task titlesTest plan
test_task_hooks.pytests pass (32 tests)test_mcp_integration.pytests passupdate_workrejects unknown column names with ValueError-are handled safely