Skip to content

allow lidarview to show multiple streams within titlebar and multiple bounding boxes within images#572

Merged
frantisekbrabec merged 2 commits intomasterfrom
feature/lidarview-multiple-titles-and-bboxes
Jul 14, 2020
Merged

allow lidarview to show multiple streams within titlebar and multiple bounding boxes within images#572
frantisekbrabec merged 2 commits intomasterfrom
feature/lidarview-multiple-titles-and-bboxes

Conversation

@frantisekbrabec
Copy link
Copy Markdown
Collaborator

--title takes a comma-separated list, will display info from all listed streams within the titlebar
also, all bboxes reported between two consecutive images will be shown within the next image

…s comma-separated list), also display all bounding boxes reported between two consecutive images
@m3d
Copy link
Copy Markdown
Member

m3d commented Jul 14, 2020

I did a single test with moon\moon-view.bat moon-round3-200713_191132.log and it does not behave as expected ... I see plenty of "rotations" in the caption bar ...
moon-caption

self.keyframes_id = names.index(keyframes_name) + 1
if title_name is not None:
self.title_id = names.index(title_name) + 1
title_list = title_name.split(",")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to argue, that argparse can handle multiple arguments, but this modification seems to be reasonable, that I would accept even comma separated names of streams ...

@frantisekbrabec
Copy link
Copy Markdown
Collaborator Author

I guess there were multiple 'rot' entries between the two consecutive images (view steps). Which of them would you like to be displayed? Or should we step by each log entry (you only see one 'rot' but the image will be the same for several steps)? Or would we attempt to aggregate/group such multiple entries (eg average)? Then the viewer would need to know the meaning of the stream so it can choose the proper aggregation function.

@m3d
Copy link
Copy Markdown
Member

m3d commented Jul 14, 2020

well, you are right, that it is not obvious which one is correct. rot is deprecated anyway and there should be filtering module soon, so we will ask for filtered IMU with lower framerate ... OK.

if title is not None:
caption += ' (' + str(title) + ')'
for t in title:
caption += ' (' + str(t) + ')'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could reduce the amount of brackets for the list, but ... that is just a detail, now separation is clear

@frantisekbrabec frantisekbrabec merged commit 3a7b6d3 into master Jul 14, 2020
@frantisekbrabec frantisekbrabec deleted the feature/lidarview-multiple-titles-and-bboxes branch July 14, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants