Fix Issue #111 + Added ip/port information from config file. #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imes generates truncation, no need for optional as they are intrinsically optional.
rjohn-v
approved these changes
Sep 30, 2025
Contributor
rjohn-v
left a comment
rjohn-v
left a comment
There was a problem hiding this comment.
Changes look good.
I have a question on the addition of the local_rosbridge.yaml file.
Also probably a good idea to edit the PR description to remove references to features that were removed.
Contributor
There was a problem hiding this comment.
What is the purpose of this local_rosbridge.yaml?
Is it meant to to be a config for turtlesim? or is it a template for users to create their own?
Collaborator
Author
There was a problem hiding this comment.
Just a config to connect to a general rosbridge server. Can be used as a template or as test file to connect to turtlesim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Issue by which IP sometimes is truncated: #111
Changes:
Optionalinconnect_to_robot. It is optional by default.Ready for Review ✅