-
Notifications
You must be signed in to change notification settings - Fork 137
Fix Issue #111 + Added ip/port information from config file. #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7c9bac5
Fix: Removed Optional for IP and PORT in connect_to_robot. This somet…
stex2005 131fae4
Added ip and port information on config yaml file
stex2005 e4e80ab
Added turtlesim.yaml
stex2005 d545486
ruff format fix
stex2005 ebd64b5
Added configuration file for local_rosbridge.yaml
stex2005 012bab4
trigger ruff check
stex2005 254aee8
Revert "Added ip and port information on config yaml file"
stex2005 eb00721
Removed ip/port
stex2005 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,4 +178,7 @@ pyrightconfig.json | |
| .vs/ | ||
|
|
||
| # camera | ||
| /camera/* | ||
| camera/* | ||
|
|
||
| # tests | ||
| tests/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Robot configuration template | ||
| # Replace this text with specific instructions and information about your robot. | ||
| # Include details on how to control it, important topics, and any special commands. | ||
| # For example: | ||
| # - Control commands (e.g., movement, actions) | ||
| # - Sensor topics (e.g., camera, lidar) | ||
| # - Safety guidelines | ||
| # - Any custom messages or services used by the robot | ||
|
|
||
| name: local_rosbridge | ||
| alias: turtlesim # Optional alias for easier reference | ||
| type: sim # or 'real' for simulation | ||
| prompts: The local_rosbridge is a generic local turtlesim robot. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this local_rosbridge.yaml?
Is it meant to to be a config for turtlesim? or is it a template for users to create their own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a config to connect to a general rosbridge server. Can be used as a template or as test file to connect to turtlesim.