Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.2.0 #231

Closed
2 tasks done
lrapetti opened this issue Jan 29, 2021 · 14 comments
Closed
2 tasks done

Release v2.2.0 #231

lrapetti opened this issue Jan 29, 2021 · 14 comments
Assignees

Comments

@lrapetti
Copy link
Member

lrapetti commented Jan 29, 2021

The last release was done almost one year ago with the v2.1.0 tag, and since then new features have been released. I think it's time to release it.

Indeed we should proceed:

  • merging devel into master
  • creating the new release

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

cc @Yeshasvitvs @traversaro @diegoferigo

@yeshasvitirupachuri
Copy link
Member

yeshasvitirupachuri commented Jan 29, 2021

@lrapetti I agree with it.

I hoped to had test/devel-rebase tested before making a new release, as this would have enabled to pull in the changes from #181 to upstream.

NOTE: PR link above update from original posting

However, at this point it is cleaner have a release from merging devel to master.

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

Good call. This will make things aligned with how wearable is maintained too.

@yeshasvitirupachuri
Copy link
Member

Before the release, may be checking the config yarp manager files for iCub visualization through #230 can be useful to have tested and committed to upstream for the next iteration of tests for retargeting.

@S-Dafarra

@yeshasvitirupachuri
Copy link
Member

@lrapetti merged devel into master branch d6fdd7a

@lrapetti
Copy link
Member Author

I hoped to had test/devel-rebase tested before making a new release, as this would have enabled to pull in the changes from #181 to upstream.

The main problem there is that it depends on a branch of iDynTree (robotology/idyntree#783), so for the time being that branch can not be merged to a stable release.

@yeshasvitirupachuri
Copy link
Member

Windows CI failed on push flow after merge at https://github.com/robotology/human-dynamics-estimation/runs/1790878536#step:9:10886, looking for IRRLICHT_INCLUDE_DIR

@lrapetti
Copy link
Member Author

lrapetti commented Feb 1, 2021

Windows CI failed on push flow after merge at https://github.com/robotology/human-dynamics-estimation/runs/1790878536#step:9:10886, looking for IRRLICHT_INCLUDE_DIR

The failure has now been fixed (#232), @Yeshasvitvs we can create the new release, what do you think?

@yeshasvitirupachuri
Copy link
Member

@lrapetti following #235 #234 #233
do you foresee any further small changes that are to be done before a release ?

@lrapetti
Copy link
Member Author

lrapetti commented Feb 3, 2021

do you foresee any further small changes that are to be done before a release ?

No, I am not planning any change, for me we can proceed with the release.

@yeshasvitirupachuri
Copy link
Member

@yeshasvitirupachuri
Copy link
Member

Expecting an automatic update of robotology-superbuild, similar to robotology/robotology-superbuild#607

@yeshasvitirupachuri
Copy link
Member

yeshasvitirupachuri commented Feb 3, 2021

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

@lrapetti We can open a separate issue for this task, and also align https://github.com/robotology/wearables with release tag branches

@traversaro
Copy link
Member

I think also we might align with the rest of robotology removing the devel branch, keeping the released tags as stable code pointers, and using master as development branch.

Just to clarify, not using devel is a strategy that make sense and I think it make sense to use for you, but it is not used by all robotology projects. At the moment is used by YARP and YCM, but not (for example) by icub-main . At the moment the master branch of this repo is still the default branch used by anyone that downloads the robotology-superbuild and compiles it with the default settings with ROBOTOLOGY_ENABLE_HUMAN_DYNAMICS , that is ROBOTOLOGY_PROJECT_TAGS set to Stable. In the future we may change this default to use the latest-releases.yaml file introduced in robotology/robotology-superbuild#596 , but probably we will need to discuss about it before doing so.

@lrapetti
Copy link
Member Author

lrapetti commented Feb 3, 2021

Cross linking the comment from @traversaro #233 (comment).

In brief this release is currently not aligned with the stable branch of iDynTree if Irrlicht is enabled. For the same reason, the CI is currenty pointing to the iDynTree devel branch (https://github.com/robotology/human-dynamics-estimation/blob/master/.github/workflows/ci.yml#L19), this will change as iDynTree will be relased (robotology/idyntree#804).

@traversaro
Copy link
Member

Expecting an automatic update of robotology-superbuild, similar to robotology/robotology-superbuild#607

FYI that scripts runs every sunday night (see https://github.com/robotology/robotology-superbuild/blob/8f415ed824730de37d886806e1db58d88117a6be/.github/workflows/update-latest-releases.yml#L9), so if you want to bump the release before manually feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants