-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legs FT IMU frames #111
Conversation
period 0.01 | ||
|
||
device inertial | ||
subdevice gazebo_imu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This IMU are not exposed in this way in the robot, so unless there is any specific reason for having them exported in this way in the Gazebo simulation (some experiments?) I would not exported them at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related gazebo-yarp-plugins issue: robotology/gazebo-yarp-plugins#383 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, since the MAS plugin in Gazebo is still under development, many of us are using the workaround of using the analog sensor interface.
But then since, it's user-specific, we could remove these files until the MAS plugin is integrated.
I do not remember the status of the PR, but if we drop the Gazebo plugins for the FT IMUs for me the PR is good to go (unless the model has been updated in the meanwhile). |
I guess @fiorisi will not have a lot of time in the coming months, so if someone wants to "adopt" the PR and implement the suggested changes you are more then welcome to do so. @prashanthr05 @nunoguedelha @lia2790 |
Thanks @traversaro. It would be nice if someone can please chek the build. Once this is fixed we can merge the PR. |
I think it would be preferable to add the Gazebo MAS plugins for the IMUs with this PR. |
We can just remove the "old" IMU conf file and then add the MAS conf files in a different PR, this PR already has a lot of stuff. |
Alright. I shall do it then. |
The build fails because the parser is looking for Here it looks for So in the yaml file, we miss filling the |
A new PR to address the review is opened #113 P.S. I didn't know how to push this existing PR, so I created a new one. Sorry for inducing this discontinuity. |
@prashanthr05 no problem, let's continue the discussion in the new PR. |
No description provided.