Skip to content

Conversation

randaz81
Copy link
Member

@randaz81 randaz81 commented Oct 13, 2021

Official iCubGenova01 conf files are now using the latest NWS/NWC layers.

Old files will remain in the Git history.

(Similar to #314)

@randaz81 randaz81 self-assigned this Oct 13, 2021
@pattacini pattacini marked this pull request as draft October 13, 2021 09:56
@pattacini
Copy link
Member

Just turned this into draft as it is WIP.
Only a general comment: could you please call the dir iCubGenova01nws to be in line with https://github.com/robotology/robots-configuration/tree/master/R1SN003nws?

@randaz81 randaz81 marked this pull request as ready for review December 13, 2021 13:03
@randaz81 randaz81 changed the title iCubGenova01_nws iCubGenova01_nws promted Dec 13, 2021
@randaz81 randaz81 changed the title iCubGenova01_nws promted iCubGenova01_nws promoted Dec 13, 2021
@randaz81 randaz81 changed the title iCubGenova01_nws promoted [WIP] iCubGenova01_nws promoted Dec 13, 2021
@randaz81 randaz81 changed the title [WIP] iCubGenova01_nws promoted iCubGenova01_nws promoted Dec 13, 2021
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @randaz81 👍🏻

@xEnVrE you may want to grab the opportunity to provide changes to the conf files required to fix mechanical bugs.

You could do that by pushing those changes to @randaz81 fork (I think he should give you permissions though) or even by forking @randaz81 fork and proposing those changes via PR (in a 2-steps procedure).

@xEnVrE
Copy link
Contributor

xEnVrE commented Dec 13, 2021

@xEnVrE you may want to grab the opportunity to provide changes to the conf files required to fix mechanical bugs.

All the modification should have been included in the last two commits updated hand calibration with Nicola's files (part1) and * updated hand calibration with Nicola's files (part2)

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps @randaz81 and @xEnVrE 👍🏻

@pattacini pattacini merged commit d2baa6c into robotology:devel Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants