-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix https://github.com/robotology/yarp/issues/1464 #1465
Conversation
I have no idea about what changed between CMake 3.9 and 3.10 to cause this behavior. |
Ok, testing right now. |
I remember that some times ago there was something related to variable expansions inside quotations marks. May it be related to this issue? |
See http://cgold.readthedocs.io/en/latest/tutorials/variables/regular.html?highlight=list#create-list for a bit more background about lists in CMake . |
Based on https://stackoverflow.com/questions/13582282/cmake-difference-between-and , I think I don't know how it was working before. |
Apparently this works on both CMake 3.9 and 3.10 . |
It works here as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@drdanz I tried to reproduce the issue in a simple example to report the regression to CMake (see https://gist.github.com/traversaro/245a770cec311be27e152039765053c1) but unfortunately everything is working properly in that example. even using CMake 3.10 . I don't know if it is worth to further investigate this issue. |
@traversaro have you tried add_executable instead of add_library? Anyway merged, thanks! 😆 |
You are right, testing now. |
Also with |
@claudiofantacci can you check if this is working fine even with CMake 3.9 ?