Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/robotology/yarp/issues/1464 #1465

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

traversaro
Copy link
Member

@claudiofantacci can you check if this is working fine even with CMake 3.9 ?

@traversaro
Copy link
Member Author

I have no idea about what changed between CMake 3.9 and 3.10 to cause this behavior.

@traversaro
Copy link
Member Author

cc @francesco-romano

@claudiofantacci
Copy link
Collaborator

Ok, testing right now.

@claudiofantacci
Copy link
Collaborator

I remember that some times ago there was something related to variable expansions inside quotations marks. May it be related to this issue?

@traversaro
Copy link
Member Author

See http://cgold.readthedocs.io/en/latest/tutorials/variables/regular.html?highlight=list#create-list for a bit more background about lists in CMake .

@traversaro
Copy link
Member Author

Based on https://stackoverflow.com/questions/13582282/cmake-difference-between-and , I think I don't know how it was working before.

@traversaro
Copy link
Member Author

Apparently this works on both CMake 3.9 and 3.10 .

@claudiofantacci
Copy link
Collaborator

It works here as well.

Copy link
Collaborator

@claudiofantacci claudiofantacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@traversaro
Copy link
Member Author

@drdanz I tried to reproduce the issue in a simple example to report the regression to CMake (see https://gist.github.com/traversaro/245a770cec311be27e152039765053c1) but unfortunately everything is working properly in that example. even using CMake 3.10 . I don't know if it is worth to further investigate this issue.

@drdanz drdanz merged commit 1e29461 into master Nov 27, 2017
@drdanz drdanz deleted the fix-cmake3-10-macos-problem branch November 27, 2017 11:33
@drdanz
Copy link
Member

drdanz commented Nov 27, 2017

@traversaro have you tried add_executable instead of add_library? Anyway merged, thanks! 😆

@traversaro
Copy link
Member Author

You are right, testing now.

@traversaro
Copy link
Member Author

Also with add_executable everything is working fine. I checked also on the CMake issue tracker if anyone had opened recently an issue related to this, but nothing pops out. For now let's see if we have similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants