Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new frameTransformClient/Server with nwc/nws architecture #2626

Merged
merged 63 commits into from
Jul 2, 2021
Merged

new frameTransformClient/Server with nwc/nws architecture #2626

merged 63 commits into from
Jul 2, 2021

Conversation

randaz81
Copy link
Member

No description provided.

@update-docs
Copy link

update-docs bot commented Jun 30, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@randaz81 randaz81 added PR Type: Feat/Enh This PR adds some new feature or enhances some part of YARP Target: YARP v3.5.0 labels Jun 30, 2021
@randaz81 randaz81 temporarily deployed to code-analysis June 30, 2021 14:49 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis June 30, 2021 14:49 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis June 30, 2021 14:49 Inactive
@PeterBowman PeterBowman mentioned this pull request Jun 30, 2021
Open
@drdanz drdanz temporarily deployed to code-analysis July 1, 2021 08:15 Inactive
@drdanz drdanz temporarily deployed to code-analysis July 1, 2021 08:15 Inactive
@drdanz drdanz temporarily deployed to code-analysis July 1, 2021 08:15 Inactive
@drdanz drdanz temporarily deployed to code-analysis July 1, 2021 08:17 Inactive
@ste93 ste93 temporarily deployed to code-analysis July 2, 2021 10:31 Inactive
@ste93 ste93 temporarily deployed to code-analysis July 2, 2021 10:32 Inactive
@ste93 ste93 temporarily deployed to code-analysis July 2, 2021 10:32 Inactive
@ste93 ste93 temporarily deployed to code-analysis July 2, 2021 10:32 Inactive
@ste93 ste93 temporarily deployed to code-analysis July 2, 2021 10:32 Inactive
@ste93 ste93 temporarily deployed to code-analysis July 2, 2021 10:32 Inactive
@randaz81 randaz81 self-assigned this Jul 2, 2021
@randaz81 randaz81 added the PR Status: Continuous Integration - OK Continuous Integration for this PR passed (invalid if commits were added or modified after this) label Jul 2, 2021
@randaz81 randaz81 force-pushed the feature/frametransform_interfaces branch from 594c036 to 8564fbc Compare July 2, 2021 13:03
ste93 and others added 23 commits July 2, 2021 15:07
@ste93 @randaz81
multiplexer now doesn't have a limit of devices attached
69c43a9
@ste93 @randaz81
fixed mispelled imports
e3a143b
@elandini84 @randaz81
Added Set_nwc_ros and Get_nwc_ros
d962439 
Added ROS nwc for both FrameTransformGet and FrammeTransformSet
@elandini84 @randaz81
Added missing EOF
0445d3e
@randaz81
fixed include file
7074fc7
@randaz81
progress on FrameTransformClient
ad062d9
@randaz81
no more compiler errors on frameTransformClient
f2194c8
@randaz81
test for FrameTransformClient
bf1123a
@randaz81
fixed iterator issue
d26a7ca
@randaz81
Improvements on rpc port
c370d89
@randaz81
improved format handing for broadcast ports using enums
897a10f
@ste93 @randaz81
updated ini parameters and documentation
50a3aae
@elandini84 @randaz81
ROS nwc node correction and yarp set_nws port name update
ee538d7
@elandini84 @randaz81
code cleanup and robotinterface xml files
b96fc3d 
Maybe, xml files should be placed somewhere else
@ste93 @randaz81
cleanup style check
baa0276
@ste93 @randaz81
fixed extra line
d0fc2a1
@elandini84 @randaz81
little fix for frameTransformGet_nwc_ros
82e4f35
@randaz81
fixed conflict after rebase
9f4f0f0
@elandini84 @randaz81
CMakeRC integration first test
f56c431 
Added support for CMakeRC library in YARP. Tests with
frameTransformClient. Everything seems to work as expected.
@elandini84 @randaz81
CMakeRC static library workaround
0734335
@elandini84 @randaz81
Clang-tidy issues addressed
dd5b9f5
@ste93 @randaz81
added frametransformclient documentation
856c4f0
@randaz81
* added changelog
c53ebbe 
* removed frameTransformRepeater
@randaz81 randaz81 force-pushed the feature/frametransform_interfaces branch from 8564fbc to c53ebbe Compare July 2, 2021 13:07
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2021

SonarCloud Quality Gate failed.

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 271 Code Smells

15.5% 15.5% Coverage
7.3% 7.3% Duplication

@randaz81 randaz81 merged commit 603766a into master Jul 2, 2021
@randaz81 randaz81 deleted the feature/frametransform_interfaces branch July 2, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdanz drdanz Awaiting requested review from drdanz

@Nicogene Nicogene Awaiting requested review from Nicogene Nicogene is a code owner

@traversaro traversaro Awaiting requested review from traversaro traversaro is a code owner

Assignees

@randaz81 randaz81

Labels
PR Status: Continuous Integration - OK Continuous Integration for this PR passed (invalid if commits were added or modified after this) PR Type: Feat/Enh This PR adds some new feature or enhances some part of YARP Resolution: Merged Target: YARP v3.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randaz81 @drdanz @ste93 @elandini84