Add type annotations to fontshell.

[knutnergaard]

Includes:

• annotation of all fontshell modules
• related fixes in base classes

[knutnergaard]

@benkiel See issues #824 and #825.

[codecov]

Codecov Report

❌ Patch coverage is 85.93350% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.34%. Comparing base (cdafc80) to head (a17256a).
⚠️ Report is 1 commits behind head on v1.

Files with missing lines	Patch %	Lines
Lib/fontParts/fontshell/glyph.py	83.33%	8 Missing and 5 partials ⚠️
Lib/fontParts/fontshell/component.py	66.66%	3 Missing and 6 partials ⚠️
Lib/fontParts/fontshell/font.py	81.63%	6 Missing and 3 partials ⚠️
Lib/fontParts/base/lib.py	0.00%	4 Missing ⚠️
Lib/fontParts/fontshell/contour.py	87.09%	1 Missing and 3 partials ⚠️
Lib/fontParts/base/groups.py	25.00%	3 Missing ⚠️
Lib/fontParts/fontshell/layer.py	85.00%	2 Missing and 1 partial ⚠️
Lib/fontParts/base/glyph.py	66.66%	0 Missing and 2 partials ⚠️
Lib/fontParts/fontshell/base.py	85.71%	1 Missing and 1 partial ⚠️
Lib/fontParts/fontshell/guideline.py	92.59%	0 Missing and 2 partials ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##               v1     #826      +/-   ##
==========================================
- Coverage   76.51%   76.34%   -0.17%     
==========================================
  Files          42       42              
  Lines        6459     6545      +86     
  Branches      966      986      +20     
==========================================
+ Hits         4942     4997      +55     
- Misses       1277     1288      +11     
- Partials      240      260      +20     

Files with missing lines	Coverage Δ
Lib/fontParts/base/base.py	85.78% <ø> (ø)
Lib/fontParts/base/guideline.py	87.35% <100.00%> (ø)
Lib/fontParts/base/image.py	95.04% <100.00%> (ø)
Lib/fontParts/base/layer.py	62.45% <100.00%> (ø)
Lib/fontParts/fontshell/features.py	100.00% <100.00%> (ø)
Lib/fontParts/fontshell/groups.py	100.00% <100.00%> (ø)
Lib/fontParts/fontshell/image.py	94.23% <100.00%> (+0.48%)	⬆️
Lib/fontParts/fontshell/info.py	100.00% <100.00%> (ø)
Lib/fontParts/fontshell/kerning.py	100.00% <100.00%> (ø)
Lib/fontParts/fontshell/point.py	100.00% <100.00%> (ø)
... and 13 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[benkiel]

Man that is a misleading name!

[knutnergaard]

Forgive me, how so?

[benkiel]

Sorry, a comment on assertCountEqual which does more than just asserting that the number is equal! Had to look it up to check that this change was correct

[knutnergaard]

Ah, indeed!☺️

[benkiel]

Changed that text