Improve requires clause parsing #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the requires clause parsing more accurate to the C++ standard. Notably, this allows having operators on parenthesized expressions. (Previously, something like
requires (mp::m == Distance) || (mp::rad == Distance)would fail because the parser would only consume the first parenthesized expression, leaving|| (mp::rad == Distance)to be unsuccessfully parsed as part of the declaration.)Relevant pages:
The parenthesized parameter list is optional in a requires expression (See https://en.cppreference.com/w/cpp/language/requires.html), but for now I left it as mandatory. I could make that optional too if you want, though.
Also, what should be done for tests? I'm having trouble building locally (running
uvx --from build pyproject-build --installer uvemitsError: You need to create a tag for this repo to use the builder), which appears to be necessary to run the tests. I also don't know if we want to add tests (and if so, where).