Skip to content

Conversation

@CodingWithFusion
Copy link
Contributor

Hello folks,
This is my first PR into your Repo. My name is Jared Leonard and I'm one of the original authors of libPlayingWithFusion. I don't have much experience with Python and need you help to confirm what I changed was sufficient. I won't have access to a roboRIO until tonight to begin testing. I wanted to create the PR now so you knew it was coming, but don't feel obligated to review immediately until testing is complete.

@virtuald virtuald force-pushed the 2025-libPlayingWithFusion branch from 66766de to 6ec93c1 Compare January 17, 2025 16:15
@virtuald virtuald merged commit d6c34b2 into robotpy:main Jan 17, 2025
27 checks passed
@virtuald
Copy link
Member

Thanks for the update! For these wrappers, I've found generally that if they build then they work fine (and our import test catches some of the weird edge cases there).

I'll tag an initial release so you can easily test it, and if you find any issues let me know.

@CodingWithFusion
Copy link
Contributor Author

Thanks so much!

@CodingWithFusion
Copy link
Contributor Author

I apologize for not getting back to you sooner. Everything seems to be working. Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants