Skip to content

Fix hardcoded alertmanager webhook URL to use Release.Name#2063

Merged
RoiGlinik merged 2 commits intomasterfrom
fix/alertmanager-webhook-release-name
May 4, 2026
Merged

Fix hardcoded alertmanager webhook URL to use Release.Name#2063
RoiGlinik merged 2 commits intomasterfrom
fix/alertmanager-webhook-release-name

Conversation

@RoiGlinik
Copy link
Copy Markdown
Contributor

Summary

  • The alertmanager webhook URL was hardcoded to robusta-runner, which breaks when the Helm release name is not robusta
  • Changed to use {{ .Release.Name }}-runner to match the actual runner service name generated by {{ include "robusta.fullname" . }}-runner

Test plan

  • helm template verified the URL renders correctly (test-release-runner.default.svc.cluster.local)
  • Deploy with a non-default release name and verify alertmanager routes to the correct runner service

🤖 Generated with Claude Code

The alertmanager webhook URL was hardcoded to `robusta-runner` which breaks
when the Helm release name is not "robusta". Use `.Release.Name` instead
to match the actual runner service name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

Docker image ready for 3d2d072 (built in 2m 31s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:3d2d072
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:3d2d072 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:3d2d072
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:3d2d072

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:3d2d072

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Walkthrough

The Alertmanager webhook receiver configuration in the Helm chart values was updated to reference the runner service using a templated Helm release name ({{ .Release.Name }}-runner) instead of a hardcoded service name (robusta-runner), enabling dynamic naming across different deployments.

Changes

Alertmanager Webhook Configuration

Layer / File(s) Summary
Configuration Wiring
helm/robusta/values.yaml
Alertmanager webhook receiver URL updated to use {{ .Release.Name }}-runner instead of hardcoded robusta-runner service name, allowing the runner service reference to be parameterized by Helm release name.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a hardcoded alertmanager webhook URL to use Release.Name instead of a static value.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (hardcoded URL), the solution (using Release.Name), and the testing approach.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/alertmanager-webhook-release-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@helm/robusta/values.yaml`:
- Around line 791-792: Replace the hardcoded release name with the chart
fullname helper so Alertmanager points to the actual Service name when
fullnameOverride or truncation is in effect: change the URL host from using {{
.Release.Name }} (e.g. "http://{{ .Release.Name }}-runner...") to use the
fullname helper (e.g. "http://{{ include \"robusta.fullname\" . }}-runner..."),
ensuring the rest of the path and variables (.Release.Namespace and
.Values.global.clusterDomain) remain unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4f7dbf96-62f0-44f2-af34-3709931ee9c2

📥 Commits

Reviewing files that changed from the base of the PR and between b147fb8 and b578d3a.

📒 Files selected for processing (1)
  • helm/robusta/values.yaml

Comment thread helm/robusta/values.yaml
@RoiGlinik RoiGlinik merged commit c3835c2 into master May 4, 2026
5 checks passed
@RoiGlinik RoiGlinik deleted the fix/alertmanager-webhook-release-name branch May 4, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants