Fix hardcoded alertmanager webhook URL to use Release.Name#2063
Fix hardcoded alertmanager webhook URL to use Release.Name#2063
Conversation
The alertmanager webhook URL was hardcoded to `robusta-runner` which breaks when the Helm release name is not "robusta". Use `.Release.Name` instead to match the actual runner service name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:3d2d072
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:3d2d072 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:3d2d072
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:3d2d072Patch Helm values in one line: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:3d2d072 |
WalkthroughThe Alertmanager webhook receiver configuration in the Helm chart values was updated to reference the runner service using a templated Helm release name ( ChangesAlertmanager Webhook Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@helm/robusta/values.yaml`:
- Around line 791-792: Replace the hardcoded release name with the chart
fullname helper so Alertmanager points to the actual Service name when
fullnameOverride or truncation is in effect: change the URL host from using {{
.Release.Name }} (e.g. "http://{{ .Release.Name }}-runner...") to use the
fullname helper (e.g. "http://{{ include \"robusta.fullname\" . }}-runner..."),
ensuring the rest of the path and variables (.Release.Namespace and
.Values.global.clusterDomain) remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4f7dbf96-62f0-44f2-af34-3709931ee9c2
📒 Files selected for processing (1)
helm/robusta/values.yaml
Summary
robusta-runner, which breaks when the Helm release name is notrobusta{{ .Release.Name }}-runnerto match the actual runner service name generated by{{ include "robusta.fullname" . }}-runnerTest plan
helm templateverified the URL renders correctly (test-release-runner.default.svc.cluster.local)🤖 Generated with Claude Code