Disable raw mode on panic #70
Conversation
Anton-4
left a comment
Anton-4
left a comment
There was a problem hiding this comment.
Thanks for your contribution @KilianVounckx!
In the atomic bool docs I saw that " This type is only available on platforms that support atomic loads and stores of u8.", so I'd like to fall back to the std bool using #[cfg(target_has_atomic = "8")]. Given that this complicates things I'd also like to move the bulk of this complexity to a separate file.
What do you think? Feel free to take your time :)
|
If I understand correctly, you want to fall back on a normal (non atomic) bool? Wouldn't this break multi-threading? |
|
Yeah, I was thinking about sacrificing that as a trade-off. |
|
Based on the discussion on zulip, let's go with the proposed |
…does this already
With expect we would crash and lose the msg that was the cause of the panic. I thought about printing an error if `disable_raw_mode()` returned an `Err` but I think it would distract from the cause of the panic, so I chose to ignore the result.
|
Thanks @KilianVounckx! |
2 participants
Fixes this issue