Add support for http extension methods #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canonical form for http method names is upper case according to rfc7231, this matches the format used in the upstream reqwest library.
Http allows any arbitrary methods defined in rfc2774 and implemented by convention. These are implemented by the upstream reqwest library so there is no reason why we can't also implement it. This removes a source of a potential crash, which is on the path of user submitted data (a http request).
Collaborator
|
I'm going to have a crack at using a tag union instead of a RocStr to cross the host boundary. I'll hand roll some glue for the method. |
Member
If you run into issues, feel free to ping me on zulip. I would guess that any issues will come from https://roc.zulipchat.com/#narrow/channel/395097-compiler-development/topic/tags.20and.20c.20abi |
lukewilliamboswell
approved these changes
Oct 18, 2024
Collaborator
lukewilliamboswell
left a comment
lukewilliamboswell
left a comment
There was a problem hiding this comment.
I attempted to avoid the RocStr, but that turned out to be more fragile than I hoped. This is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for any arbitrary http method. I discovered this while trying to implement a server that would respond to the QUERY (draft) method, which caused a crash when I tried it. Since this functionality is supported in the upstream rust http libraries, I can't see any reason why it cannot be supported here too.