Update HTTP package to new zig-based roc compiler syntax.#1
Merged
Conversation
| @@ -0,0 +1,2 @@ | |||
| # https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods | |||
| Method := [OPTIONS, GET, POST, PUT, DELETE, HEAD, TRACE, CONNECT, PATCH, Unknown(Str)] No newline at end of file | |||
Contributor
There was a problem hiding this comment.
What do you think about nesting this under Request? It would be Http.Request.Method then
Contributor
Author
There was a problem hiding this comment.
Unfortunately, it seems like the compiler doesn't currently support nested types... I'm going to open an issue for this.
#beginners > Type module which depends on a type defined within?
lukewilliamboswell
approved these changes
May 30, 2026
Contributor
lukewilliamboswell
left a comment
lukewilliamboswell
left a comment
There was a problem hiding this comment.
I'm going to add some things in a follow up. Thank you @imclerran for making a start on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.