Various changes #7628
Merged
Various changes #7628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll enums lowercase, ModuleEnv to use arena allocator co-authored-by: Sam Mohr <sam@sammohr.dev>
Comment on lines
+330
to
+333
| // @Anthony / @Josh shouldn't these be added to the ModuleEnv (env) so they are in the arena | ||
| // and then they are cleaned up when the arena is deinitialized at the end of program compilation | ||
| // or included in the cached build | ||
| defer std.testing.allocator.free(parse_ast.errors); |
Collaborator
Author
There was a problem hiding this comment.
I left a comment here for you. I didn't want to make the change in this PR as it was already getting large and might help to discuss first.
smores56
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR;
Ident