Merged
Conversation
- Fix get_all_news() parameter handling to support date ranges as documented - Add backward compatibility for existing code using single parameter - Enhance market info functions with robust HTML parsing and fallback selectors - Add comprehensive error handling for network issues and parsing failures - Fix get_market_inf(), get_latest_pe(), and get_market_inf_more_data() functions Resolves issues with NoneType errors and parsing failures in market data functions.
- Fix Store utility with proper file saving mechanism and custom filename support - Fix Tickers utility with correct file path resolution using absolute paths - Create missing tickers.json file with 397 current trading symbols - Add proper directory creation and error handling for file operations - Ensure tickers.json is included in package distribution Resolves file saving issues and missing dependency errors.
- Update version from 1.1.3 to 1.1.4 to reflect major fixes - Add comprehensive changelog entry documenting all improvements - Document enhanced error handling and robustness improvements - List all fixed functions and their improvements - Update package metadata with new version This version represents a significant improvement in reliability and functionality.
- Replace deprecated .ix with .iloc in get_session() and get_token() - Fix test function calls to provide required arguments for set_session/set_token - Achieve 100% function reliability (24/24 functions working) - All functions now fully compatible with modern pandas versions Resolves remaining pandas compatibility warnings and completes the package fixes.
|
@masud1901 awesome brother! you did so much work and I wanna ask do you use this data to make calculated decision?how? |
Contributor
Author
|
Thank you.. I am trying to do a project with this package. I was searching an api that could fetch real time data.. I would transform them and wanted to find sudden volume differences and other indicators that could show unfamiliar behavior of the stock in the short term.. like historically, stock A hasn't experienced this much fluctuation at this time of year, so why is it doing so now? This kinda questions. In a braod strock, trying to predict insider trading. I don't know I could pull this off or not. Just an idea. Also tryng to add some methods based on some finance papers. This package seems to be stable but takes a lot of time to fetch all the data. So maybe not real time analysis but daily analysis could happen. My masters final is going on so I am not giving that much time here. But will start to work on it soon. Also you could see that I dont do that much coding by hand. I am good with prompting. |
|
I'm kinda working on it too.
The main problem is dse doesn't actually provide api/easy realtime data not
even historical data easily.
.
Also, THE main problem in Bangladesh stock market is we can't sell the same
day we buy, we have to sell 2days later. I thought to find so edge doing
scalping but this kills it 😐
.
I'm also trying to get a api/something so i can analysis trades by quantity
something like orderbook api.
.
Bangladesh stock market isn't for algo trading! It's retail heavy and
volume is very low.
…On Tue, Oct 21, 2025, 2:13 AM Akmol Masud Ayon ***@***.***> wrote:
*masud1901* left a comment (rochi88/bdshare#11)
<#11 (comment)>
Thank you.. I am trying to do a project with this package. I was searching
an api that could fetch real time data.. I would transform them and wanted
to find sudden volume differences and other indicators that could show
unfamiliar behavior of the stock in the short term.. like historically,
stock A hasn't experienced this much fluctuation at this time of year, so
why is it doing so now? This kinda questions. In a braod strock, trying to
predict insider trading. I don't know I could pull this off or not. Just an
idea. Also tryng to add some methods based on some finance papers. This
package seems to be stable but takes a lot of time to fetch all the data.
So maybe not real time analysis but daily analysis could happen. My masters
final is going on so I am not giving that much time here. But will start to
work on it soon.
Also you could see that I dont do that much coding by hand. I am good with
prompting.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWZI5HS4KY2GMZIUF4TAKXT3YU67VAVCNFSM6AAAAACGSPC7E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMRTGU3TAMBVGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Btw you can't actually spot insider trading cause there's various method as
iceberg, reserve, twap etc.
…On Tue, Oct 21, 2025, 2:13 AM Akmol Masud Ayon ***@***.***> wrote:
*masud1901* left a comment (rochi88/bdshare#11)
<#11 (comment)>
Thank you.. I am trying to do a project with this package. I was searching
an api that could fetch real time data.. I would transform them and wanted
to find sudden volume differences and other indicators that could show
unfamiliar behavior of the stock in the short term.. like historically,
stock A hasn't experienced this much fluctuation at this time of year, so
why is it doing so now? This kinda questions. In a braod strock, trying to
predict insider trading. I don't know I could pull this off or not. Just an
idea. Also tryng to add some methods based on some finance papers. This
package seems to be stable but takes a lot of time to fetch all the data.
So maybe not real time analysis but daily analysis could happen. My masters
final is going on so I am not giving that much time here. But will start to
work on it soon.
Also you could see that I dont do that much coding by hand. I am good with
prompting.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWZI5HS4KY2GMZIUF4TAKXT3YU67VAVCNFSM6AAAAACGSPC7E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMRTGU3TAMBVGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Owner
|
Dear Akmol Masud Ayon Thank you so much for this incredible contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Complete BDShare Package Fixes - Version 1.1.4
🎯 Summary
This PR represents a complete transformation of the BDShare package, achieving 100% function reliability with comprehensive fixes, enhanced error handling, and full pandas compatibility.
🏆 Final Results
🔧 Issues Fixed
1. News Functions ✅
get_all_news()function signature didn't match documentationget_all_news(start, end, code)as documentedbdshare/stock/news.py2. Market Data Functions ✅
get_market_inf(),get_latest_pe(),get_market_inf_more_data()returning NoneType errorsbdshare/stock/market.py3. Store Utility ✅
Store().save()function not creating files properlybdshare/util/store.py4. Tickers Utility ✅
tickers.jsonfile causing FileNotFoundErrortickers.jsonwith 397 current trading symbolsbdshare/util/tickers.py,bdshare/util/tickers.json5. Session/Token Functions ✅
.ixattribute.ixwith.ilocfor modern pandas compatibilitybdshare/util/session.py,bdshare/util/upass.py📊 Comprehensive Test Results
Trading Data Functions (100% Working)
get_current_trade_data()- 397 recordsget_current_trade_data('GP')- 1 recordget_dsex_data()- 326 recordsget_current_trading_code()- 397 recordsget_hist_data()- 1,312 recordsget_basic_hist_data()- 1,312 recordsget_close_price_data()- 2 recordsget_last_trade_price_data()- 396 recordsNews Functions (100% Working)
get_agm_news()- 209 recordsget_all_news()- Date range support workingget_all_news('GP')- 195 recordsMarket Data Functions (100% Working)
get_market_inf()- 30 recordsget_latest_pe()- 421 recordsget_market_inf_more_data()- 2 recordsget_market_depth_data()- 2 recordsget_company_inf()- 23 itemsUtility Functions (100% Working)
get_session()- Workingset_session()- Fixed parameter issueget_token()- Workingset_token()- Fixed parameter issueStore(df).save()- File saving workingTickers()- 397 symbols loaded🚀 Version Update
🧪 Testing
All functions have been thoroughly tested with:
📝 Commit History
9f5c2c3- Fix core stock data functions with enhanced error handling5978de9- Fix utility functions and add missing dependenciesdc5dc12- Bump version to 1.1.4 and update changelog92a846a- Fix pandas compatibility issues in session/token functions✅ Ready for Review
This PR represents a complete transformation of the BDShare package:
🎉 Impact
📦 Package Status
🔄 Breaking Changes
None - All changes maintain backward compatibility
Branch:
fix-major-function-issues-v1.1.4Target:
mainType: Bug Fix / Enhancement
Status: Complete and Ready for Merge
This PR transforms BDShare from a partially functional package to a 100% reliable, production-ready solution for Dhaka Stock Exchange data access.