Conversation
arv
added a commit
that referenced
this pull request
Mar 27, 2026
Followup to #28 ... these should not have been committed.
arv
added a commit
that referenced
this pull request
Mar 27, 2026
Followup to #28 ... these should not have been committed.
arv
added a commit
that referenced
this pull request
Mar 27, 2026
Followup to #28 ... these should not have been committed.
Contributor
|
Please carefully test all the cases here
https://github.com/rocicorp/zero-virtual/blob/main/HACKING.md manually.
They are subtle and easy to break. Add any new ones that need to be tested.
…On Fri, Mar 27, 2026 at 4:03 AM Erik Arvidsson ***@***.***> wrote:
Merged #28 <#28> into main.
—
Reply to this email directly, view it on GitHub
<#28?email_source=notifications&email_token=AAATUBGDRLSFRQPP2V77X7T4S2C4BA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEMZZG4ZTGNRZGI3TPJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-23973369277>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATUBDE263NI2KG6TMDG434S2C4BAVCNFSM6AAAAACXCAMFB2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRTHE3TGMZWHEZDONY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Contributor
Author
The only one I didn't manually test is the settling. That one is hard to break... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sticking to only using the Navigation API for consistency.
When a permalink changes we check if we need to scroll or not.
Fixes #21