Conversation
aboodman
force-pushed
the
fix/invalidate-stale-permalink-state
branch
from
56e53bb to
5aaadea
Compare
When using scroll position restoration with permalinkState, the saved state would be restored even if the list context had changed (e.g., after clearing a search filter). This caused the virtualizer to restore an incorrect scroll position for the new list. This change: - Adds optional listContextParams to PermalinkHistoryState type - Computes effectivePermalinkState that returns null if saved context doesn't match current context (using JSON.stringify for deep equality) - Uses effectivePermalinkState instead of permalinkState for restoration - Includes listContextParams when saving state via onPermalinkStateChange Backwards compatible: if no listContextParams was saved, the state is used as-is.
aboodman
force-pushed
the
fix/invalidate-stale-permalink-state
branch
from
5aaadea to
3c35776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using scroll position restoration with
permalinkState, the saved state would be restored even if the list context had changed (e.g., after clearing a search filter). This caused the virtualizer to restore an incorrect scroll position for the new list.Changes:
listContextParamsfield toPermalinkHistoryStatetypeeffectivePermalinkStatethat returnsnullif saved context doesn't match current (by identity)listContextParamswhen saving state viaonPermalinkStateChangeTest plan