Conversation
Agent-Logs-Url: https://github.com/rockcarver/frodo-cli/sessions/005ec6e7-444c-4e13-830e-e6318832b0f5 Co-authored-by: vscheuber <28791378+vscheuber@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rockcarver/frodo-cli/sessions/005ec6e7-444c-4e13-830e-e6318832b0f5 Co-authored-by: vscheuber <28791378+vscheuber@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update integration batch workflow selection criteria
Switch integration-batch PR readiness filtering to GitHub check runs
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dry-run selection was skipping PRs that appeared green in the GitHub UI because the workflow relied on legacy combined commit status (
/commits/{sha}/status) and requiredstate=success. This updates integration-batch selection to use check runs, aligned with current GitHub checks behavior.Selection criteria: move from combined status to Checks API
GET /repos/$REPO/commits/$head_sha/check-runstotal_count == 0→reason: no check runs foundstatus != completed→reason: checks pending{success, skipped, neutral}→reason: checks not successfulWorkflow output/summary consistency
$GITHUB_OUTPUT.reason(instead of legacystate).Docs alignment
docs/INTEGRATION.mdselection rules to document check-runs-based gating.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/rockcarver/frodo-cli/releases/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-warnings --enable-source-maps --experimental-loader file:///home/REDACTED/work/frodo-cli/frodo-cli/dist/loader.cjs /home/REDACTED/work/frodo-cli/frodo-cli/dist/app.cjs shell t@users.noreply.github.com --depth 2 REDACTED config-manager pull saml -f test/e2e/fr-config-manager-pull-config/saml.json -D testDir22 git conf�� ame URL --file test/e2e/exports/all/allAlphaResourceTypes.resourcetype.authz.json --global(http block)/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-warnings --enable-source-maps --experimental-loader file:///home/REDACTED/work/frodo-cli/frodo-cli/dist/loader.cjs /home/REDACTED/work/frodo-cli/frodo-cli/dist/app.cjs shell es/.bin/node gpg.program(http block)/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-warnings --enable-source-maps --experimental-loader file:///home/REDACTED/work/frodo-cli/frodo-cli/dist/loader.cjs /home/REDACTED/work/frodo-cli/frodo-cli/dist/app.cjs shell in/node pull.rebase(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Update Integration Batch workflow selection criteria in
rockcarver/frodo-cli.Context: In dry-run, PRs that appear green/ready in GitHub UI were skipped because workflow used legacy combined commit status endpoint
/repos/{owner}/{repo}/commits/{sha}/statusand required.state == success.Required change:
.github/workflows/integration-batch.yml, replace the "Filter to PRs with successful combined status" logic to use GitHub Checks API (check runs) instead.GET /repos/$REPO/commits/$head_sha/check-runs(usegh api)..total_count == 0: skip the PR (reason: no check runs found)..status != "completed": skip (reason: checks pending)..conclusionnot in {success,skipped,neutral}: skip (reason: checks not successful).$GITHUB_OUTPUT.Deliverable: Open a PR with these changes.
The following is the prior conversation context from the user's chat exploration (may be truncated):
User: @copilot Accepted Confirmation: Confirm agent session
Assistant: I can add it for you, but I can’t make repository changes from this chat right now.
What you’ll need to do:
rockcarver/frodo-cli.github/workflows/integration-batch.yml(the YAML we finalized with dry-run).github/workflows/pipeline.ymlso bump type is derived from the merged PR’s labels (release:patch|minor|major), defaulting to prerelease, and failing if:docs/PIPELINE.mdto remove trigger phrase guidance and document the label-based behavior + failure-on-direct-push ruleIf you want, paste the current
docs/CONTRIBUTE.mdhere (or link it) and I’ll draft the exact edits for:integration-batch,integrated,integration-failed)User: What does this mean exactly: "I can add it for you, but I can’t make repository changes from this chat right now."?
Where can you add it if you cannot make repository changes? Just trying to understand what you can and what you cannot do.
Assistant: I misspoke. In this chat I can make repository changes, but only by using the GitHub tools that create a PR / push commits. I can’t “reach into your local repo,” and I also can’t change anything without a repo/branch target and your confirmation—which you’ve already given by accepting the agent session.
What I can do here:
rockcarver/frodo-cli(via a PR) that:.github/workflows/integration-batch.yml.github/workflows/pipeline.ymlto use PR labels (release:patch|minor|major) and fail on direct pushes / ambiguous PR mappingdocs/PIPELINE.mddocs/CONTRIBUTE.mdand add something likedocs/INTEGRATION.mdWhat I cannot do here:
Also, the Copilot coding agent is already running on your request and will produce a PR you can review/merge. You can track it here:
If you open that link, you should see the PR (or a task that becomes a PR) once it’s ready. If you want, I can also summarize the diff and call out anything that needs manual repo-setting changes (like adding the new labels).
User: OK, so if I understand you correctly, what I need to do is:
Assistant: Yes — that’s the right sequence, with two small additions.
What you need to do
Create labels in
rockcarver/frodo-clirelease:patchrelease:minorrelease:majorintegration-batchintegratedintegration-failedReview and merge the PR the agent creates
.github/workflows/integration-batch.yml(with dry-run).github/workflows/pipeline.ymlupdated to use PR labels and **fail on direct pushes / ambigu...This pull request was created from Copilot chat.