Skip to content

rockchip_spi compilation fails #221

@HerrMuellerluedenscheid

Description

Hi,
I'm working with an RK3399 hooked onto an orangepi 4b. I'm trying to access the sysfs /dev/spi* interface and failed so far. I recompiled the development kernel and found that rockchip_spi compilation fails.
Might this be the reason for the missing sysfs interface to spi?

drivers/spi/spi-rockchip.c: In function 'rockchip_spi_config':
drivers/spi/spi-rockchip.c:567:4: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'inc_zone_state'? [-Werror=implicit-function-declaration]
    pinctrl_select_state(rs->dev->pins->p,
    ^~~~~~~~~~~~~~~~~~~~
    inc_zone_state
drivers/spi/spi-rockchip.c:567:32: error: 'struct device' has no member named 'pins'
    pinctrl_select_state(rs->dev->pins->p,
                                ^~
drivers/spi/spi-rockchip.c:570:32: error: 'struct device' has no member named 'pins'
    pinctrl_select_state(rs->dev->pins->p,
                                ^~
drivers/spi/spi-rockchip.c:571:18: error: 'struct device' has no member named 'pins'
           rs->dev->pins->default_state);
                  ^~
drivers/spi/spi-rockchip.c: In function 'rockchip_spi_probe':
drivers/spi/spi-rockchip.c:797:25: error: implicit declaration of function 'pinctrl_lookup_state'; did you mean 'inc_zone_state'? [-Werror=implicit-function-declaration]
  rs->high_speed_state = pinctrl_lookup_state(rs->dev->pins->p,
                         ^~~~~~~~~~~~~~~~~~~~
                         inc_zone_state
drivers/spi/spi-rockchip.c:797:53: error: 'struct device' has no member named 'pins'
  rs->high_speed_state = pinctrl_lookup_state(rs->dev->pins->p,
                                                     ^~
drivers/spi/spi-rockchip.c: In function 'rockchip_spi_suspend':
drivers/spi/spi-rockchip.c:864:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_sleep_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/spi/spi-rockchip.c: In function 'rockchip_spi_resume':
drivers/spi/spi-rockchip.c:875:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_default_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
scripts/Makefile.build:277: recipe for target 'drivers/spi/spi-rockchip.o' failed
make[2]: *** [drivers/spi/spi-rockchip.o] Error 1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions