Skip to content

feat: enhance update table filters use case and add comprehensive tests #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Aug 11, 2025
Merged

feat: enhance update table filters use case and add comprehensive tests #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions backend/src/entities/table-filters/use-cases/update-table-filters.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ export class UpdateTableFiltersUseCase
}

const updatedFilterEntity = buildNewTableFiltersEntity(updatedTableFilterData);
for (const key in updatedFilterEntity) {
// eslint-disable-next-line security/detect-object-injection
if (updatedFilterEntity[key] === undefined) {
// eslint-disable-next-line security/detect-object-injection
delete updatedFilterEntity[key];
}
}
const updatedFilters = Object.assign(filtersToUpdate, updatedFilterEntity);
await this._dbContext.tableFiltersRepository.save(updatedFilters);
return buildCreatedTableFilterRO(updatedFilters);
Expand Down
21 changes: 21 additions & 0 deletions backend/test/ava-tests/saas-tests/table-filters-e2e-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,28 @@ test.serial(`${currentTest} should return updated table filters`, async (t) => {
t.is(updateTableFiltersRO.hasOwnProperty('createdAt'), true);
t.is(updateTableFiltersRO.hasOwnProperty('updatedAt'), true);
t.is(updateTableFiltersRO.name, updatedFiltersDTO.name);
t.is(updateTableFiltersRO.id, createTableFiltersRO.id);
t.deepEqual(updateTableFiltersRO.filters, updatedFiltersDTO.filters);

// should return updated table filters
const getUpdatedTableFiltersResponse = await request(app.getHttpServer())
.get(`/table-filters/${createConnectionRO.id}/all/?tableName=${testTableName}`)
.set('Cookie', firstUserToken)
.set('Content-Type', 'application/json')
.set('Accept', 'application/json');
const getUpdatedTableFiltersRO = JSON.parse(getUpdatedTableFiltersResponse.text);
t.is(Array.isArray(getUpdatedTableFiltersRO), true);
t.is(getUpdatedTableFiltersRO.length, 1);
getUpdatedTableFiltersRO.forEach((el) => {
t.is(el.hasOwnProperty('id'), true);
t.is(el.hasOwnProperty('name'), true);
t.is(el.hasOwnProperty('filters'), true);
t.is(el.hasOwnProperty('dynamic_column'), true);
t.is(el.hasOwnProperty('createdAt'), true);
t.is(el.hasOwnProperty('updatedAt'), true);
t.is(el.name, updatedFiltersDTO.name);
t.deepEqual(el.filters, updatedFiltersDTO.filters);
});
} catch (e) {
console.error(e);
t.fail();
Expand Down