header: fix login / sign up buttons visibility#1428
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where login and sign up buttons were not displaying correctly in the header when query parameters were present in the URL. The fix ensures that only the path portion of the URL (without query parameters) is used for route matching.
- Strips query parameters from the URL path before comparing routes
- Removes commented-out code and reorganizes imports in the upgrade component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/app/app.component.ts | Fixed URL parsing to strip query parameters, ensuring correct route matching for login/signup button visibility |
| frontend/src/app/components/upgrade/upgrade.component.ts | Cleaned up commented code and reorganized imports (MatIconModule moved earlier) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| this.page = this.router.routerState.snapshot.url; | ||
| this.page = this.router.routerState.snapshot.url.split('?')[0]; | ||
|
|
||
| console.log('Navigated to page:', this.page); |
There was a problem hiding this comment.
This console.log statement appears to be debugging code and should be removed before merging to production. Debug logging statements can clutter the console and are typically not needed in production code.
Suggested change
| console.log('Navigated to page:', this.page); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.