removed dependencies from rocketadmin agent #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR consolidates database dependencies from the rocketadmin-agent package into the shared-code package, removing testing infrastructure and simplifying the agent's dependency footprint.
Key changes:
- Moved database client dependencies (knex, mongodb, mysql2, pg, oracledb, ssh2, tedious) from agent to shared-code
- Relocated ibm_db as an optional dependency to shared-code along with its packageExtensions configuration
- Removed all testing infrastructure (jest, ts-jest, supertest) and test-related scripts from the agent
- Removed get-port and @types/pg from agent dependencies
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yarn.lock | Removed unused dependency entries for Babel, Jest, Istanbul, and other testing/build dependencies that are no longer needed by the agent |
| shared-code/package.json | Added ibm_db as an optional dependency and configured packageExtensions for node-gyp requirement |
| rocketadmin-agent/package.json | Removed database client libraries, testing dependencies, jest configuration, and test scripts; kept only agent-specific runtime and CLI dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.