Skip to content

Skip test for primary key name validation due to incorrect name handling #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Artuomka merged 1 commit into from
Jan 21, 2026
Merged

Skip test for primary key name validation due to incorrect name handling #1514

Artuomka merged 1 commit into from
Jan 21, 2026

Conversation

@Artuomka
Copy link
Collaborator

@Artuomka Artuomka commented Jan 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 21, 2026 15:13
@Artuomka Artuomka merged commit 0780671 into main Jan 21, 2026
8 checks passed
@Artuomka Artuomka deleted the backend_table_settings_rework branch January 21, 2026 15:13
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR skips a test that validates whether the API correctly rejects requests with incorrect primary key names in MSSQL schema operations. The PR title indicates this is due to "incorrect name handling" but doesn't fix the underlying issue.

Changes:

  • Skips a test for primary key name validation by changing test.serial to test.skip
Comments suppressed due to low confidence (108)

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3533

  • Skipping this test reduces coverage for an important validation scenario - ensuring that incorrect primary key names are properly rejected by the API. This test validates that passing a fake primary key name (fakeKeyName) returns a 400 error with PRIMARY_KEY_INVALID message. If the underlying behavior is broken, it should be fixed rather than skipping the test. If this is a temporary workaround, consider using test.failing() instead of test.skip() to document that the test is expected to fail until the bug is fixed.
test.skip(
  `${currentTest} should throw an exception, when primary key passed in request has incorrect name`,
  async (t) => {
    const connectionToTestMSSQL = getTestData(mockFactory).connectionToTestMSSQLSchemaInDocker;
    const firstUserToken = (await registerUserAndReturnUserInfo(app)).token;
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =
      await createTestTableForMSSQLWithChema(connectionToTestMSSQL);

    testTables.push(testTableName);

    const createConnectionResponse = await request(app.getHttpServer())
      .post('/connection')
      .send(connectionToTestMSSQL)
      .set('Cookie', firstUserToken)
      .set('Content-Type', 'application/json')
      .set('Accept', 'application/json');
    const createConnectionRO = JSON.parse(createConnectionResponse.text);
    t.is(createConnectionResponse.status, 201);

    const idForSearch = 1;
    const foundRowInTableResponse = await request(app.getHttpServer())
      .get(`/table/row/${createConnectionRO.id}?tableName=${testTableName}&fakeKeyName=${idForSearch}`)
      .set('Cookie', firstUserToken)
      .set('Content-Type', 'application/json')
      .set('Accept', 'application/json');

    t.is(foundRowInTableResponse.status, 400);
    const { message } = JSON.parse(foundRowInTableResponse.text);
    t.is(message, Messages.PRIMARY_KEY_INVALID);
  },
);

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2137

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2137

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2137

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2190

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2190

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2190

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2215

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2215

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2215

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2243

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2243

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2243

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2270

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2270

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2270

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2299

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2353

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2353

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2383

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2429

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2429

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2437

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2486

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2486

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2494

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2494

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2494

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2533

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2533

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2541

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2590

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2590

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2600

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2654

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2654

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2665

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2701

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2740

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2778

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2816

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2855

  • Unused variable testEntitiesSeedsCount.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2895

  • Unused variable testEntitiesSeedsCount.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2935

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2935

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2935

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2975

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2975

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2985

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2985

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:2985

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3023

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3023

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3033

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3033

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3033

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3073

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3073

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3083

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3083

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3083

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3123

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3123

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3133

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3133

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3133

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3173

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3173

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3183

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3183

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3183

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3222

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3222

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3234

  • Unused variable testTableColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3234

  • Unused variable testEntitiesSeedsCount.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3234

  • Unused variable testTableSecondColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3273

  • Unused variable primaryColumns.
    const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3273

  • Unused variable pagination.
    const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3286

  • Unused variable testTableColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3286

  • Unused variable testEntitiesSeedsCount.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3286

  • Unused variable testTableSecondColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3317

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3317

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3358

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3358

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3358

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3387

  • Unused variable testTableColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3387

  • Unused variable testEntitiesSeedsCount.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3387

  • Unused variable testTableSecondColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3418

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3418

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3418

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3448

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3448

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3448

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3478

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3478

  • Unused variable testEntitiesSeedsCount.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3478

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3508

  • Unused variable testTableColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3508

  • Unused variable testEntitiesSeedsCount.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3508

  • Unused variable testTableSecondColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3540

  • Unused variable testTableColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3540

  • Unused variable testEntitiesSeedsCount.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3540

  • Unused variable testTableSecondColumnName.
    const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3572

  • Unused variable testTableColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3572

  • Unused variable testTableSecondColumnName.
  const { testTableName, testTableColumnName, testEntitiesSeedsCount, testTableSecondColumnName } =

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3621

  • Unused variable primaryColumns.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts:3621

  • Unused variable pagination.
  const { rows, primaryColumns, pagination } = getTableRowsRO;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backend/test/ava-tests/non-saas-tests/non-saas-table-mssql-schema-e2e.test.ts
const { message } = JSON.parse(foundRowInTableResponse.text);
t.is(message, Messages.PRIMARY_KEY_INVALID);
});

Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is being skipped without any accompanying comment or documentation explaining why. While the PR title mentions "incorrect name handling," there's no indication of whether this is a known bug, a temporary workaround, or a tracking issue to re-enable the test. Consider adding a comment above the test explaining why it's skipped and reference a tracking issue for fixing the underlying problem.

Suggested change
// TODO(ISSUE-1234): Re-enable this test once incorrect primary key name handling
// in the MSSQL table row endpoint is fixed. Currently the endpoint does not
// properly treat an incorrect primary key name as invalid, causing this test
// to fail intermittently. Tracking: ISSUE-1234.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Artuomka