fix: replace data-ph-no-capture attribute with ph-no-capture class#1585
Merged
fix: replace data-ph-no-capture attribute with ph-no-capture class#1585
Conversation
PostHog supports class-based no-capture which is more reliable than data attributes for preventing sensitive data capture in session replays. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the frontend templates to use PostHog’s class-based opt-out (ph-no-capture) instead of the data-ph-no-capture attribute, improving reliability of preventing sensitive UI content from being captured in PostHog session replays/autocapture.
Changes:
- Replaced
data-ph-no-captureattributes withph-no-captureCSS class across multiple Angular templates. - Applied the class to code editor wrappers, table cells, filter chips, and audit/log detail fields where sensitive values may appear.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/app/components/ui-components/record-edit-fields/markdown/markdown.component.html | Marks markdown editor container as ph-no-capture. |
| frontend/src/app/components/ui-components/record-edit-fields/json-editor/json-editor.component.html | Marks JSON editor container as ph-no-capture. |
| frontend/src/app/components/ui-components/record-edit-fields/code/code.component.html | Marks code editor container as ph-no-capture. |
| frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.html | Marks static filter chips as ph-no-capture. |
| frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html | Marks active filter chips and table cells as ph-no-capture. |
| frontend/src/app/components/dashboard/db-table-view/db-table-row-view/db-table-row-view.component.html | Marks row preview values as ph-no-capture. |
| frontend/src/app/components/charts/chart-edit/chart-edit.component.html | Marks SQL editor container as ph-no-capture. |
| frontend/src/app/components/audit/info-dialog/info-dialog.component.html | Marks log details fields as ph-no-capture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostHog supports class-based no-capture which is more reliable than data attributes for preventing sensitive data capture in session replays.