Skip to content

Refactor route configuration to remove dashboardId from widget generation endpoint #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 2 commits into from
Feb 27, 2026
Merged

Refactor route configuration to remove dashboardId from widget generation endpoint #1641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64efaa2
Refactor route configuration to remove dashboardId from widget genera…
Artuomka Feb 27, 2026
8d8033c
Merge branch 'main' into backend_remove_dashboard_id_from_generate_pa…
Artuomka Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/entities/visualizations/panel-position/panel-position.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class PanelPositionModule {
.apply(AuthMiddleware)
.forRoutes(
{ path: '/dashboard/:dashboardId/widget/:connectionId', method: RequestMethod.POST },
{ path: '/dashboard/:dashboardId/widget/generate/:connectionId', method: RequestMethod.POST },
{ path: '/widget/generate/:connectionId', method: RequestMethod.POST },
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The route path has been changed from /dashboard/:dashboardId/widget/generate/:connectionId to /widget/generate/:connectionId, but the frontend code at frontend/src/app/services/dashboards.service.ts:149 still references the old path. This will cause API calls from the frontend to fail with 404 errors. The frontend code must be updated to use the new route path /widget/generate/${connectionId} instead of /dashboard/${dashboardId}/widget/generate/${connectionId}.

Copilot uses AI. Check for mistakes.
{ path: '/dashboard/generate-table-dashboard/:connectionId', method: RequestMethod.POST },
{ path: '/dashboard/:dashboardId/widget/:widgetId/:connectionId', method: RequestMethod.PUT },
{ path: '/dashboard/:dashboardId/widget/:widgetId/:connectionId', method: RequestMethod.DELETE },
Expand Down
Loading