Conversation
…rove error handling
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Cedar authorization evaluation to load/evaluate policies on a per-group basis, aiming to improve resiliency and error visibility when individual group policies are invalid.
Changes:
- Replaced “combine all group policies into one static policy set” with per-group policy evaluation and early-return on first
allow. - Introduced per-group authorization error logging during evaluation.
- Replaced cached per-user policy loading with a per-group policy loader.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+205
to
+209
| const result = cedarWasm.isAuthorized(call as Parameters<typeof cedarWasm.isAuthorized>[0]); | ||
| if (result.type === 'success') { | ||
| if (result.response.decision === 'allow') { | ||
| return true; | ||
| } |
Comment on lines
+218
to
222
| private async loadPoliciesPerGroup(connectionId: string, userGroups: Array<GroupEntity>): Promise<string[]> { | ||
| const groups = await this.globalDbContext.groupRepository.findAllGroupsInConnection(connectionId); | ||
| const userGroupIdSet = new Set(userGroupIds); | ||
| const policyTexts = groups | ||
| const userGroupIdSet = new Set(userGroups.map((g) => g.id)); | ||
| return groups | ||
| .filter((g) => userGroupIdSet.has(g.id)) |
Comment on lines
+210
to
+212
| } else { | ||
| this.logger.warn(`Cedar authorization error for group policy: ${JSON.stringify(result.errors)}`); | ||
| } |
Comment on lines
+189
to
193
| const groupPolicies = await this.loadPoliciesPerGroup(connectionId, userGroups); | ||
| if (groupPolicies.length === 0) return false; | ||
|
|
||
| const entities = buildCedarEntities(userId, userGroups, connectionId, tableName, dashboardId); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.