add/edit row: fix fields order taking into account columns_view#1755
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR aims to make the add/edit row form respect the user’s column visibility/order preferences (via columns_view / list_fields) when determining the order of fields shown.
Changes:
- Updated add/edit row field ordering logic to prefer
columns_viewwhen present, falling back tolist_fieldsor row keys. - Updated table view “column visibility change” handler to persist both
columns_viewand an explicitly orderedlist_fields(selected columns first, then hidden).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/app/components/db-table-row-edit/db-table-row-edit.component.ts | Tries to order edit/add form fields using columns_view before list_fields. |
| frontend/src/app/components/dashboard/db-table-view/db-table-view.component.ts | Persists list_fields ordering alongside columns_view when toggling column visibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (res.columns_view && res.columns_view.length) { | ||
| this.fieldsOrdered = [...res.columns_view].filter((field) => shownFieldsList.includes(field)); |
| if (res.columns_view && res.columns_view.length) { | ||
| this.fieldsOrdered = [...res.columns_view]; |
No description provided.