Skip to content

Remove api container references#1085

Merged
0xfornax merged 1 commit intomasterfrom
remove-api-container
Apr 24, 2026
Merged

Remove api container references#1085
0xfornax merged 1 commit intomasterfrom
remove-api-container

Conversation

@0xfornax
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

Coverage Report

@github-actions
Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/config 0.00% (ø)
github.com/rocket-pool/smartnode/shared/services/config 3.36% (ø)
github.com/rocket-pool/smartnode/shared/types/config 4.73% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/review-page.go 0.00% (ø) 989 (-13) 0 989 (-13)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/step-finished.go 0.00% (ø) 507 (-13) 0 507 (-13)
github.com/rocket-pool/smartnode/shared/services/config/consensus-common-config.go 19.57% (ø) 46 9 37
github.com/rocket-pool/smartnode/shared/services/config/execution-common-config.go 19.57% (ø) 46 9 37
github.com/rocket-pool/smartnode/shared/services/config/external-configs.go 4.17% (ø) 648 27 621
github.com/rocket-pool/smartnode/shared/services/config/fallback-configs.go 15.28% (ø) 72 11 61
github.com/rocket-pool/smartnode/shared/services/config/rocket-pool-config.go 0.97% (ø) 6995 68 6927
github.com/rocket-pool/smartnode/shared/services/config/smartnode-config.go 1.38% (ø) 1228 17 1211
github.com/rocket-pool/smartnode/shared/types/config/types.go 22.22% (ø) 36 8 28

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax 0xfornax merged commit e75f0fc into master Apr 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant