Skip to content

Refactor build.sh a bit#479

Merged
jclapis merged 1 commit intorocket-pool:v2from
jshufro:jms/v2/build
Apr 8, 2024
Merged

Refactor build.sh a bit#479
jclapis merged 1 commit intorocket-pool:v2from
jshufro:jms/v2/build

Conversation

@jshufro
Copy link
Copy Markdown
Contributor

@jshufro jshufro commented Apr 7, 2024

  1. Removes the requirement that build.sh must be run from the project's parent dir
  2. Ignores build/ subtree
  3. Cleans up artifact naming a bit to reduce complexity of build docker files and remove a bunch of mv from the script
  4. Only pushes to docker hub if -u is passed. (allows for local development with the 'official' build pipeline artifacts)

@jshufro jshufro force-pushed the jms/v2/build branch 5 times, most recently from 77560aa to bfa8d00 Compare April 8, 2024 02:30
@jclapis jclapis merged commit cd0f1dc into rocket-pool:v2 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants