Hardcode pre-merge receipt for mainnet interval 0 #844
Merged
Conversation
jshufro
reviewed
Jun 3, 2025
Contributor
There was a problem hiding this comment.
all new code in this file should be in a new function
jshufro
reviewed
Jun 4, 2025
| // Get the event info for a rewards snapshot using the Atlas getter | ||
| func GetRewardsEvent(rp *rocketpool.RocketPool, index uint64, rocketRewardsPoolAddresses []common.Address, opts *bind.CallOpts) (bool, RewardsEvent, error) { | ||
| // Check if the client is requesting interval 0 on mainnet, then return the hardcoded RewardsEvent | ||
| ok, eventDataInterval_0, err := getMainnetInterval0RewardsEvent(rp, index) |
Contributor
There was a problem hiding this comment.
golang semantics are probably data, ok, err := i think
jshufro
approved these changes
Jun 4, 2025
0xfornax
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ec-interfaceandec-managerto support grabbing thechainIDRewardsEventfor interval 0, the only pre-merge interval on mainnet.Interval 0 snapshot