chore(cicd): skip Vercel ignition deploys + ignore release-output.log#155
Merged
Conversation
Disables the publish-ignition jobs in prepare-release.yml and release.yml with `if: false` until the rocketicons.io hosting story is settled. The project has a half-finished Vercel-to-AWS-Amplify migration in flight (amplify.yml is present, amplify/ scaffold exists), the VERCEL_TOKEN org secret is from May 2024 and likely expired, and rocketicons.io currently returns NXDOMAIN — so the Vercel deploy step has been failing every release attempt without changing anything users see. Inline comments on both workflows explain why and point at the re-enable path. Crucially, npm publish is independent of the Vercel jobs in release.yml, so disabling them does NOT block the rocketicons package release. Also: - Add release-output.log to .gitignore (the file the hardened "Prepare tag or release" step writes to). The releaser auto-pushed this temp file in commit a4fbdd0; removing it from tracking here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables the Vercel ignition-deploy jobs in
prepare-release.ymlandrelease.ymlwithif: falseuntil the rocketicons.io hosting story is settled. Unblocks the v0.3.0rocketiconsrelease: the package will publish to npm cleanly, the Vercel preview/prod-deploy steps no longer fail every run.Context
While debugging the previous prepare-release runs we noticed:
amplify.ymlandamplify/exist in the repo (Amplify migration started)VERCEL_TOKENorg secret is from May 2024 (almost certainly expired)rocketicons.iocurrently returnsNXDOMAINSo Vercel-bound steps are pure noise right now. The
npm publishstep inrelease.ymlruns in a completely separate job (create-release) and is unaffected by skippingpublish-ignition*.Changes
prepare-release.yml:if: falseon thepublish-ignitionjob (preview deploy), with inline reasoningrelease.yml:if: falseon bothpublish-ignitionandpublish-ignition-for-releasejobs.gitignore: addrelease-output.log(the temp file the hardened "Prepare tag or release" step writes to — got accidentally auto-pushed in commita4fbdd041by the releaser, removing it from tracking here)Test plan
prepare-release— expectprepare-artifacts✓ +publish-ignitionskipped (instead of failure)release.ymlruns — expect tag created, npm publish succeeds, Vercel jobs skipped, GitHub Release created fromrelease-notes.mdRe-enabling
The
if: falseis intentionally on three jobs so it's easy to grep. When the hosting decision lands (Amplify, Coolify, or back to Vercel with a fresh token), drop theif: falselines, swap in the new deploy implementation inpublish-ignition.ymlif needed, rotate any stale tokens, done.