fix(cli): replace process::exit with error return for --max-weight#155
Closed
rocketman-code wants to merge 1 commit intomainfrom
Closed
fix(cli): replace process::exit with error return for --max-weight#155rocketman-code wants to merge 1 commit intomainfrom
rocketman-code wants to merge 1 commit intomainfrom
Conversation
3 tasks
Owner
Author
|
Closing: patch contents already on main. Branch has zero diff after rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
Summary
MaxWeightExceededvariant toErrorenum with structured fields (kind,weight,module_count,threshold)process::exit(1)inrun_tracewithErr(Error::MaxWeightExceeded { .. })so the error flows through the centralized error handler inmain()Displayimpl formats the same user-facing message as before, so CLI output is unchangedTest plan
cargo test --workspacepasses (all 338 tests)cargo clippy --workspace --all-targets -- -D warningscleancargo fmt --checkclean