fix(parser): extract side-effect imports from requested_modules#173
Merged
rocketman-code merged 1 commit intomainfrom Feb 22, 2026
Merged
fix(parser): extract side-effect imports from requested_modules#173rocketman-code merged 1 commit intomainfrom
rocketman-code merged 1 commit intomainfrom
Conversation
Side-effect imports (import "./polyfill") were silently dropped because extract_all only read ModuleRecord.import_entries, which requires bindings. Scan requested_modules for import statements not covered by import/export entries, with a fast-path skip when all entries are already covered (the common case). Closes #171
rocketman-code
force-pushed
the
fix/side-effect-imports
branch
from
2a15223 to
56093fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import "./polyfill") were silently dropped becauseextract_allonly readModuleRecord.import_entries, which requires bindingsextract_side_effect_importsto scanrequested_modulesfor import statements not covered by import/export entriesimport "cloudflare/shims/web"in CLI entry)Test plan
side_effect_import,side_effect_import_with_named,side_effect_import_not_duplicatedCloses #171