replacing cms block ID with block code [#9] #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketweb
commented
Jan 5, 2024
Model/Service/DumpCmsDataService.php
Outdated
| $varDirectory = $this->filesystem->getDirectoryWrite(DirectoryList::VAR_DIR); | ||
| $varPath = $this->directoryList->getPath(DirectoryList::VAR_DIR); | ||
| $workingDirPath = $varPath . '/sync_cms_data'; | ||
| $this->blocksMapping = $this->getBlocksMapping(); |
Collaborator
Author
There was a problem hiding this comment.
Don't do DB calls inside of __construct() method, __construct should only be used to initialize the variables, not populate them.
Model/Service/DumpCmsDataService.php
Outdated
| { | ||
| $blocksMapping = []; | ||
| $searchCriteria = $this->criteriaBuilder; | ||
| $blocksList = $this->blockRepository->getList($searchCriteria->create()); |
Collaborator
Author
There was a problem hiding this comment.
You are pulling every block no matter how many are we actually exporting. Refactor this:
- Move calling this outside of __construct()
- add pagination support when pulling the data
- Call this method inside of replaceBlockIds() (pull all IDs for every call of replaceBlockId()), use the ->blocksMapping as a cache so it doesn't pull the same blockIDs over and over again
rocketweb
commented
Jan 6, 2024
Model/Service/DumpCmsDataService.php
Outdated
| if (isset($this->blocksMapping[$blockId])) { | ||
| $identifier = $this->blocksMapping[$blockId]; | ||
| $content = str_replace("block_id=\"$blockId\"", "block_id=\"$identifier\"", $content); | ||
| if (!isset($this->blocksMapping[$blockId])) { |
Collaborator
Author
There was a problem hiding this comment.
Better, but this approach now pulls from DB for every new block ID. I suggest pulling the data per replaceBlockIds() call. After if (isset($blockIds[1])) { you have a collection of $blockIds, use that to pull all of Ids at once. This way, we pull from DB only once per CMS block.
rocketweb
pushed a commit
that referenced
this pull request
Jan 8, 2024
rocketweb
pushed a commit
that referenced
this pull request
Jan 8, 2024
adding support for is_tailwindcss_jit_enabled [#6]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.