Skip to content

Conversation

@neelchauhan
Copy link
Contributor

@neelchauhan neelchauhan commented Mar 2, 2024

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

Copy link
Member

@wsoyinka wsoyinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neelchauhan - Thank you . Great suggestions for improvements here 👍

For clarity and styling reasons the original author for this guide prefers the Shell foobar > syntax for shell/command prompts . @jimcat8 - any additional thoughts ?

Please revert those particular changes and this PR will be ready for merging :-)

e.g. lines 114, 132, 134 etc etc....

@sspencerwire
Copy link
Contributor

@neelchauhan I generally agree with all of your corrections here. I've had a problem with this procedure from the beginning though @jimcat8 simply because part of the process is to install MySQL from source. Having a procedure in place that uses third-party software, and is required to complete the procedure is OK. BUT, MariaDB is the Rocky Linux equivalent package and installing this is trivial. On top of that, package updates and dependencies will continue as long as the OS is supported. When we install a package from source (in this case MySQL) and install the dependencies associated with it, what happens when a dependency updates that does not work with the version of MySQL installed? The answer is that it breaks the procedure. Rewriting this procedure a little more to instead use MariaDB, rather than MySQL means that this document will not cause a problem down the road. It's a suggestion, but a strong one that I think @wsoyinka would agree with.

 * Reinstate `Shell(192.168.100.7) >`
 * Use Rocky Linux/RHEL MariaDB instead of MySQL from source
@neelchauhan neelchauhan requested a review from wsoyinka March 2, 2024 19:09
@github-actions
Copy link

github-actions bot commented Mar 2, 2024

Test results for 9dc70da:

Number of broken URLs: 2

URL,RESULT,FILENAME
 https://azure.microsoft.com/en-us/,failed,guides/automation/templates-automation-packer-vsphere.md
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neelchauhan !! We appreciate the work.

@wsoyinka
Copy link
Member

wsoyinka commented Mar 2, 2024

@jimcat8 - I notice that there are 3 different IPs referenced in the original document - [192.168.100.(5-7)] Was this a minor oversight or are there 3 different systems involved in the procedures ?

I also notice that @neelchauhan has helpfully tried to standardize on a single IP - 192.168.100.7 for consistency.

@jimcat8 please review the changes and confirm your approval. Especially the mysql Vs. mariadb changes that we debating.

@neelchauhan
Copy link
Contributor Author

@jimcat8 - I notice that there are 3 different IPs referenced in the original document - [192.168.100.(5-7)] Was this a minor oversight or are there 3 different systems involved in the procedures ?

Multiple IPs are involved in this tutorial.

@jimcat8
Copy link
Contributor

jimcat8 commented Mar 3, 2024

First of all, installing MySQL with source code is for better performance release, and if you want to upgrade or adopt a variant of MySQL, you can export the data directly.
Secondly, the roles of the three machines are described at the beginning of the document, mainly to show that the e-mail system is made up of different components.
In a production environment, it is not recommended to put all components on the same machine, which is actually decoupling.
Finally, DBMS usually doesn't change much unless a major version is updated
@wsoyinka @sspencerwire

@wsoyinka
Copy link
Member

wsoyinka commented Mar 3, 2024

First of all, installing MySQL with source code is for better performance release, and if you want to upgrade or adopt a variant of MySQL, you can export the data directly. Secondly, the roles of the three machines are described at the beginning of the document, mainly to show that the e-mail system is made up of different components. In a production environment, it is not recommended to put all components on the same machine, which is actually decoupling. Finally, DBMS usually doesn't change much unless a major version is updated @wsoyinka @sspencerwire

@jimcat8 - Very good. Please review and approve or disapprove these contributions by @neelchauhan to this doc. Thank you :-)

@jimcat8
Copy link
Contributor

jimcat8 commented Mar 3, 2024

You don't have to use the same method as the author. Installing Mysql from a repository or docker is also possible.

@wsoyinka
Copy link
Member

wsoyinka commented Mar 3, 2024

Very good. Please review and approve or disapprove these contributions by @neelchauhan to this doc. Thank you :-)

You don't have to use the same method as the author. Installing Mysql from a repository or docker is also possible.

@jimcat8 - Understood! Would you prefer that installing mysql from source instructions remain as you had it originally ?

@jimcat8
Copy link
Contributor

jimcat8 commented Mar 3, 2024

Very good. Please review and approve or disapprove these contributions by @neelchauhan to this doc. Thank you :-)

You don't have to use the same method as the author. Installing Mysql from a repository or docker is also possible.

@jimcat8 - Understood! Would you prefer that installing mysql from source instructions remain as you had it originally ?

yep

@wsoyinka
Copy link
Member

wsoyinka commented Mar 3, 2024

Very good. Please review and approve or disapprove these contributions by @neelchauhan to this doc. Thank you :-)

You don't have to use the same method as the author. Installing Mysql from a repository or docker is also possible.

@jimcat8 - Understood! Would you prefer that installing mysql from source instructions remain as you had it originally ?

yep

@jimcat8 - Understood and thank you. I will recommend that @neelchauhan forks this doc present an alternative approach to doing this !

@jimcat8
Copy link
Contributor

jimcat8 commented Mar 3, 2024

"03-single-machine-email-system.md"

Example:postfix + dovecot + bind + MariaDB

@wsoyinka @neelchauhan

@sspencerwire sspencerwire merged commit faefd31 into rocky-linux:main Mar 3, 2024
wsoyinka added a commit to wsoyinka/documentation that referenced this pull request Mar 3, 2024
@wsoyinka wsoyinka mentioned this pull request Mar 3, 2024
wsoyinka added a commit that referenced this pull request Mar 3, 2024
@neelchauhan neelchauhan deleted the postfix2 branch November 29, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants