-
Notifications
You must be signed in to change notification settings - Fork 366
Basic email system: Big overhaul of grammar and formatting #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neelchauhan - Thank you . Great suggestions for improvements here 👍
For clarity and styling reasons the original author for this guide prefers the Shell foobar > syntax for shell/command prompts . @jimcat8 - any additional thoughts ?
Please revert those particular changes and this PR will be ready for merging :-)
e.g. lines 114, 132, 134 etc etc....
|
@neelchauhan I generally agree with all of your corrections here. I've had a problem with this procedure from the beginning though @jimcat8 simply because part of the process is to install MySQL from source. Having a procedure in place that uses third-party software, and is required to complete the procedure is OK. BUT, MariaDB is the Rocky Linux equivalent package and installing this is trivial. On top of that, package updates and dependencies will continue as long as the OS is supported. When we install a package from source (in this case MySQL) and install the dependencies associated with it, what happens when a dependency updates that does not work with the version of MySQL installed? The answer is that it breaks the procedure. Rewriting this procedure a little more to instead use MariaDB, rather than MySQL means that this document will not cause a problem down the road. It's a suggestion, but a strong one that I think @wsoyinka would agree with. |
* Reinstate `Shell(192.168.100.7) >` * Use Rocky Linux/RHEL MariaDB instead of MySQL from source
Test results for 9dc70da:
|
sspencerwire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neelchauhan !! We appreciate the work.
|
@jimcat8 - I notice that there are 3 different IPs referenced in the original document - [192.168.100.(5-7)] Was this a minor oversight or are there 3 different systems involved in the procedures ? I also notice that @neelchauhan has helpfully tried to standardize on a single IP - 192.168.100.7 for consistency. @jimcat8 please review the changes and confirm your approval. Especially the mysql Vs. mariadb changes that we debating. |
Multiple IPs are involved in this tutorial. |
|
First of all, installing MySQL with source code is for better performance release, and if you want to upgrade or adopt a variant of MySQL, you can export the data directly. |
@jimcat8 - Very good. Please review and approve or disapprove these contributions by @neelchauhan to this doc. Thank you :-) |
|
@jimcat8 - Understood! Would you prefer that installing mysql from source instructions remain as you had it originally ? |
yep |
@jimcat8 - Understood and thank you. I will recommend that @neelchauhan forks this doc present an alternative approach to doing this ! |
|
"03-single-machine-email-system.md" Example: |
…ocky-linux#1854)" This reverts commit faefd31.
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)