Skip to content

Conversation

@ambaradan
Copy link
Contributor

Author checklist (to be completed by original Author)

  • Is this document a good fit for the Rocky project ?
  • Is this a non-English contribution?
  • Title and Author MetaTags have been inserted into the document
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (to be completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • 5th Pass (Include document in TOC)
  • Final pass/approval (Final Review)

In this file I made some changes to the admonitions because I realized that translating the tags of the admonitions these were translated into Italian but all became of type note (blue color) !!!
So inspired by what was found in netwok.md:

!!! Notes "Memory aid"

I changed the admonitions tags like this:

!!! Warning Attenzione
!!! Tip Consiglio

This from my visualization tests produces both the right color and translation.
Can you please check it out?

I think it is important that the admonitions have the right color to indicate the level of attention.
Thank you
@sspencerwire
Copy link
Contributor

@ambaradan Thank you so much for continuing your translations! I probably won't get to work this PR until Monday, so be patient and feel free to push other translations in the meantime. Thanks again! Steve

@ambaradan
Copy link
Contributor Author

ambaradan commented Nov 13, 2021 via email

@wsoyinka
Copy link
Member

@ambaradan - Just a quick note to say a big thank you for your contributions :-)

ambaradan and others added 9 commits November 14, 2021 18:15
In this file I made some changes to the admonitions because I realized that translating the tags of the admonitions these were translated into Italian but all became of type note (blue color) !!!
So inspired by what was found in netwok.md:

!!! Notes "Memory aid"

I changed the admonitions tags like this:

!!! Warning Attenzione
!!! Tip Consiglio

This from my visualization tests produces both the right color and translation.
Can you please check it out?

I think it is important that the admonitions have the right color to indicate the level of attention.
Thank you
@sspencerwire sspencerwire changed the base branch from main to edit_367 November 15, 2021 15:56
@sspencerwire sspencerwire merged commit 675826e into rocky-linux:edit_367 Nov 15, 2021
@ambaradan
Copy link
Contributor Author

so from what I see the right way to have the translation in the admonitions is to enclose the translation itself between two double quotation marks

Example:
!!! Note " Aiuto alla memoria "

is that correct?

@sspencerwire
Copy link
Contributor

so from what I see the right way to have the translation in the admonitions is to enclose the translation itself between two double quotation marks

Example: !!! Note " Aiuto alla memoria "

is that correct?

@ambaradan You are correct. If you leave the Note (warning, tip, etc.) as it is, it will stay in English, but if you put in Note "Nota" then you will get that instead.

@sspencerwire
Copy link
Contributor

Feel free to push through edits to fix whatever you like. Thanks again for your contributions!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants