Skip to content

Conversation

@tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Jan 23, 2022

With a desire to help improve the quality and accuracy of the documentation generated for the plugin, I am submitting this pull request to update the use of VMware product names and product terminology, where found.

  • Updates any occurrence of "Vsphere" to "vSphere".
  • Updates any occurrence of "VMWare" to "VMware".
  • Updates any occurrence of incorrect use of "vCenter" to "vCenter Server".
  • Updates some incorrect use of vSphere terminology.

For a detailed project that also covers the deployment of Rocky Linux and other operating systems using the latest in vSphere, Packer, and the Packer Plugin for vSphere, please visit my project vmware-samples/packer-examples-for-vsphere. You may wish to include it as a reference.

Rocky Documentation checklist

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • 5th Pass (Include document in TOC)
  • Final pass/approval (Final Review)

- Updates any occurrence of "Vsphere" to "vSphere".
- Updates any occurrence of "VMWare" to "VMware".
- Updates any occurrence of incorrect use of "vCenter" to "vCenter Server".
- Updates some incorrect use of vSphere terminology.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@sspencerwire
Copy link
Contributor

@tenthirtyam Thanks very much for your contribution here. I've confirmed that your changes are accurate. I'm going to ask the original author to take a look as well, in case he would like to add your referral link. Thank you again for your contribution!!

@alemorvan Would you take a look at the reference link included and see if you would like to add it to the document?

@alemorvan
Copy link
Contributor

alemorvan commented Jan 23, 2022

Hello @tenthirtyam,
Thank you for this contribution. It's true that I haven't really paid much attention to VMware terminology. My apologies!
Steven, ok to validate this PR.
I looked at Ryan's project. I didn't know that VMware had this project available on github. Unfortunately I didn't find it during my research. I already knew about the Bento project and what Jeff Geerling is doing.
@sspencerwire, as Ryan's project (which is just perfect) is a bit of a reference, we could add it (with his agreement ;-) ) as a reference at the bottom of the page.
Maybe a "Going Further" section, "References". Actually, I don't know what term to use.

I'll also have to go back to this page to change the scripts to HCL format instead of JSON.

@alemorvan
Copy link
Contributor

I take advantage of having an expert to answer my questions.
As for the moment the configuration of the VM by the tools is not yet possible, according to you @tenthirtyam what is the right method? Go through cloud-init ?
Could you keep us informed if the situation changes?
Thx

@sspencerwire
Copy link
Contributor

Hello @tenthirtyam, Thank you for this contribution. It's true that I haven't really paid much attention to VMware terminology. My apologies! Steven, ok to validate this PR. I looked at Ryan's project. I didn't know that VMware had this project available on github. Unfortunately I didn't find it during my research. I already knew about the Bento project and what Jeff Geerling is doing. @sspencerwire, as Ryan's project (which is just perfect) is a bit of a reference, we could add it (with his agreement ;-) ) as a reference at the bottom of the page. Maybe a "Going Further" section, "References". Actually, I don't know what term to use.

I'll also have to go back to this page to change the scripts to HCL format instead of JSON.

I believe that @tenthirtyam is giving us permission to link to his project. If you could just verify that Ryan, we can do some tweaking of this on Monday. I'm going to keep this PR active just so I can maintain an easy resource to grab that link. Thanks again for your contribution!

@tenthirtyam
Copy link
Contributor Author

Absolutely, please feel free to reference this project as an additional reference.

Regarding guest customization, yes cloud-init is recommended. v21.3 and later has the new upstream VMware datasource which can be used. It used to be a VMware project but it was merged into cloud-int last year. I plan to add this to the project in the next major set of updates, too and I know that VMware is looking to better support Rocky Linux as a guest OS.

Have a great weekend!

@sspencerwire sspencerwire merged commit 7379f66 into rocky-linux:main Jan 24, 2022
@tenthirtyam tenthirtyam deleted the docs-fix-names-terms branch January 24, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants