-
Notifications
You must be signed in to change notification settings - Fork 368
A beginner's guide to installing and setting up the latest version of Nginx #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alemorvan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good job @EzequielBruni
But in my opinion, there are security aspects that need to be reworked.
I took the liberty of adding a few small comments and putting some commands between quotes.
Feel free to accept or refuse my suggestions!
|
@EzequielBruni before I do any merging, etc., I'll let you and @alemorvan decide how to deal with @alemorvan suggestions. I did see one typo in my cursory glance through the text and conversation. It's in the conclusion section and I'm sure that you would have caught it at some point and wanted to fix it: (this bit) The basic installation and configuration of Nginx are easy If they are installations and configurations, are is correct, but in this case, it should be "is"... yes?? This is going to be a great addition to the documentation. Thanks for doing this Ezequiel!! |
|
As @EzequielBruni said at the end, a guide for multi-host miss. |
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
|
@alemorvan I was thinking that multi-site should be a separate document, and I can probably handle that, though of course I welcome your input. It'll need to cover making/organizing multiple config files, how to make a sites-enabled workflow, stuff like that. All-in-one documents have their advantages, but sometimes people see the length of a doc and think, "Man, I do NOT have time for this." Since no one's paying me by the article here, I thought it might be nice to break things down into more manageable steps. |
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Author checklist (to be completed by original Author)
Rocky Documentation checklist (to be completed by Rocky team)