Skip to content

Conversation

@EzequielBruni
Copy link
Collaborator

@EzequielBruni EzequielBruni commented Feb 2, 2022

Author checklist (to be completed by original Author)

  • Is this document a good fit for the Rocky project ?
  • Is this a non-English contribution?
  • Title and Author MetaTags have been inserted into the document
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (to be completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • 5th Pass (Include document in TOC)
  • Final pass/approval (Final Review)

Copy link
Contributor

@alemorvan alemorvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good job @EzequielBruni
But in my opinion, there are security aspects that need to be reworked.
I took the liberty of adding a few small comments and putting some commands between quotes.
Feel free to accept or refuse my suggestions!

@sspencerwire
Copy link
Contributor

sspencerwire commented Feb 2, 2022

@EzequielBruni before I do any merging, etc., I'll let you and @alemorvan decide how to deal with @alemorvan suggestions. I did see one typo in my cursory glance through the text and conversation. It's in the conclusion section and I'm sure that you would have caught it at some point and wanted to fix it:

(this bit)

The basic installation and configuration of Nginx are easy

If they are installations and configurations, are is correct, but in this case, it should be "is"... yes??

This is going to be a great addition to the documentation. Thanks for doing this Ezequiel!!

@alemorvan
Copy link
Contributor

As @EzequielBruni said at the end, a guide for multi-host miss.
I don't know well nginx, but I can help.

EzequielBruni and others added 3 commits February 2, 2022 18:47
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
@EzequielBruni
Copy link
Collaborator Author

@alemorvan I was thinking that multi-site should be a separate document, and I can probably handle that, though of course I welcome your input. It'll need to cover making/organizing multiple config files, how to make a sites-enabled workflow, stuff like that. All-in-one documents have their advantages, but sometimes people see the length of a doc and think, "Man, I do NOT have time for this."

Since no one's paying me by the article here, I thought it might be nice to break things down into more manageable steps.

EzequielBruni and others added 10 commits February 2, 2022 18:54
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
Co-authored-by: Antoine Le Morvan <antoine@le-morvan.com>
@sspencerwire sspencerwire merged commit 5ba4fea into main Feb 4, 2022
@EzequielBruni EzequielBruni deleted the install-nginx-mainline branch February 9, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants