Skip to content

Conversation

@NezSez
Copy link
Contributor

@NezSez NezSez commented Mar 10, 2022

Author checklist (Completed by original Author)

  • Contribution a good fit for the Rocky project? Title and Author MetaTags inserted ?
  • Is this a non-English contribution?
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • Final pass/approval (Final Review)

NezSez added 5 commits March 9, 2022 17:32
New Gemstone file on viewing the .config settings at compile time for installed kernels.
Closes #602
Add two examples, Gentoo and Arch
Re-worded for Wale's comments, added some extra info
@NezSez NezSez marked this pull request as draft March 10, 2022 06:20
@NezSez
Copy link
Contributor Author

NezSez commented Mar 10, 2022

Please convert this to a draft until I can verify the last statement on some distribution which actually has the configs option installed, or I can compile and test a RL kernel with it enabled.

@EzequielBruni
Copy link
Collaborator

Please convert this to a draft until I can verify the last statement on some distribution which actually has the configs option installed, or I can compile and test a RL kernel with it enabled.

It actually shows up as a draft to me. Couldn't merge it if I wanted to... unless I made it not a draft. I'll leave it as-is.

@NezSez
Copy link
Contributor Author

NezSez commented Mar 10, 2022

It does still show as a draft. I'd think it would stop the checks when in draft mode though and they are still running.

@wsoyinka
Copy link
Member

Looks great @NezSez !

@NezSez NezSez changed the title Nez sez new gemstone kernel configs New gemstone for determining kernel configs Mar 11, 2022
@NezSez
Copy link
Contributor Author

NezSez commented Mar 11, 2022

Should I just mark my PR ready to review...it's going to take a long time before I can verify that the line
ls /sys/module/configs
is correct (it should be, but finding a distro that actually uses configs mod by default is a problem).
I have a few more notes to make, then it should be ready.

@NezSez NezSez marked this pull request as ready for review March 11, 2022 20:15
@NezSez
Copy link
Contributor Author

NezSez commented Mar 11, 2022

So the checkbox for "Is this a non-English contribution?" is a check that you checked if it was non-english or not, rather than indicating that the submission actually is non-english? If I don't check it, all tests will not pass, but if I do check it so the tests will complete, does any CI/CD workflows actually do anything like hand it off to crowdin etc?

@NezSez NezSez requested a review from wsoyinka March 11, 2022 21:27
@sspencerwire
Copy link
Contributor

So the checkbox for "Is this a non-English contribution?" is a check that you checked if it was non-english or not, rather than indicating that the submission actually is non-english? If I don't check it, all tests will not pass, but if I do check it so the tests will complete, does any CI/CD workflows actually do anything like hand it off to crowdin etc?

That is correct!

@sspencerwire
Copy link
Contributor

So the checkbox for "Is this a non-English contribution?" is a check that you checked if it was non-english or not, rather than indicating that the submission actually is non-english? If I don't check it, all tests will not pass, but if I do check it so the tests will complete, does any CI/CD workflows actually do anything like hand it off to crowdin etc?

That is correct!

Don't worry about the passing of the checks, as we can override that one.

@sspencerwire sspencerwire changed the base branch from main to edit_606 March 12, 2022 02:33
@sspencerwire
Copy link
Contributor

merging into an editing branch

@sspencerwire sspencerwire merged commit 7a2d114 into rocky-linux:edit_606 Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants