Skip to content

Conversation

@jimcat8
Copy link
Contributor

@jimcat8 jimcat8 commented Apr 10, 2022

Author checklist (Completed by original Author)

  • Contribution a good fit for the Rocky project? Title and Author MetaTags inserted ?
  • Is this a non-English contribution?
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • Final pass/approval (Final Review)

```

Renames `file1` to `file2`, if `file2` already exists, it will be replaced by `file1`.
Renames `file1` to `file2`, if `file2` already exists, Replace the contents of the file with `file1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would read better split into two sentences, personally.

Suggested change
Renames `file1` to `file2`, if `file2` already exists, Replace the contents of the file with `file1`.
Renames `file1` to `file2`. If `file2` already exists, replace the contents of the file with `file1`.

Copy link
Contributor

@hbjydev hbjydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Left a comment on one bit though, potential to improve readability there a little.

@alemorvan
Copy link
Contributor

Thx guys for this review.

| `Space` | Move down one page. |
| `PgUp` and `PgDn` | Move up or down one page. |
| `Begin` and `End` | Move to the beginning or end of a file. |
| <kbd>h</kbd> | Help. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jimcat8, @antoine, etc... I don't think that the commands are going to show up in the table at all. The reason is that they are inside another formatting element. I think what I'll do is pull this down and take a look, but my guess is that they won't show.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was incorrect. It does work as you have it changed.

@sspencerwire sspencerwire changed the base branch from main to edit_669 April 11, 2022 13:32
@sspencerwire sspencerwire merged commit ec056e1 into rocky-linux:edit_669 Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants