-
Notifications
You must be signed in to change notification settings - Fork 367
fix db-delete to db-drop script name #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey thank you @bamtests for this fix. Unfortunately, we can't accept the fix for the Italian translation, as that must be done through the Crowdin interface. The source (English) document we can accept. Once the source is pulled back in, the translation interface will pick up the change in the source document in the Italian translation. Can you push edit your PR here to just include the fix for the English (source) document? Then we can merge. Thank you again! |
|
@all-contributors please add @bamtests for contribution. |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors please add @bamtests for content |
|
I've put up a pull request to add @bamtests! 🎉 |
|
|
||
| ```bash | ||
| vi db-delete.sh | ||
| vi db-drop.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bamtests Did you see my note regarding not including the Italian translation as part of this PR? If you are unsure, I can pull this down and delete the Italian portion myself. |
|
@sspencerwire yes my apologies it took a minute to get back to github but that is done! I appreciate adding me as a contributor for such a minor change lol...I may have more tho to earn it! |
Test results for 0e340ac:
|
|
Thanks!!! |
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)