Skip to content

Conversation

@bamtests
Copy link

@bamtests bamtests commented Oct 30, 2022

Author checklist (Completed by original Author)

  • Contribution a good fit for the Rocky project? Title and Author MetaTags inserted ?
  • Is this a non-English contribution?
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • Final pass/approval (Final Review)

@sspencerwire
Copy link
Contributor

Hey thank you @bamtests for this fix. Unfortunately, we can't accept the fix for the Italian translation, as that must be done through the Crowdin interface. The source (English) document we can accept. Once the source is pulled back in, the translation interface will pick up the change in the source document in the Italian translation. Can you push edit your PR here to just include the fix for the English (source) document? Then we can merge. Thank you again!

@sspencerwire
Copy link
Contributor

@all-contributors please add @bamtests for contribution.

@allcontributors
Copy link
Contributor

@sspencerwire

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@sspencerwire
Copy link
Contributor

@all-contributors please add @bamtests for content

@allcontributors
Copy link
Contributor

@sspencerwire

I've put up a pull request to add @bamtests! 🎉


```bash
vi db-delete.sh
vi db-drop.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sspencerwire
Copy link
Contributor

@bamtests Did you see my note regarding not including the Italian translation as part of this PR? If you are unsure, I can pull this down and delete the Italian portion myself.

@bamtests
Copy link
Author

bamtests commented Nov 1, 2022

@sspencerwire yes my apologies it took a minute to get back to github but that is done! I appreciate adding me as a contributor for such a minor change lol...I may have more tho to earn it!

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Test results for 0e340ac:

Number of broken URLs: 0

URL,RESULT,FILENAME

@sspencerwire
Copy link
Contributor

Thanks!!!

@sspencerwire sspencerwire merged commit 82496c8 into rocky-linux:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants