Skip to content

Conversation

@SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Nov 6, 2022

punctuation

Author checklist (Completed by original Author)

  • Contribution a good fit for the Rocky project? Title and Author MetaTags inserted ?
  • Is this a non-English contribution?
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • Final pass/approval (Final Review)

@SergeCroise SergeCroise marked this pull request as ready for review November 6, 2022 04:58
:heavy_check_mark: install and manage collections;
:heavy_check_mark: install and manage roles;.
:heavy_check_mark: install and manage roles.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are back to that ";" again. The ";" is fine I think, just not with the ";." as shown. If you correct it to be a period, then all of the items should also be ended with a period. IMO

Copy link
Contributor Author

@SergeCroise SergeCroise Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @sspencerwire, please review 😀

| `list` | display the name and the version of installed roles. |
| `info` | display information about a role. |
| `info` | display information about a role. |
| `init` | generate a skeleton of a new role. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there is nothing wrong with this change, it isn't really necessary either. Personally, I prefer to line up all of the table elements as you are doing here, but the table should display fine w/o adding the space to make it line up with the others.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Test results for 320c0a6:

Number of broken URLs: 0

URL,RESULT,FILENAME

@sspencerwire sspencerwire merged commit 2db9c33 into rocky-linux:main Nov 6, 2022
@SergeCroise SergeCroise deleted the patch-1 branch November 6, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants