Skip to content

Conversation

@SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Nov 11, 2022

punctuation,
spelling (kickstart response file)

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@SergeCroise SergeCroise marked this pull request as ready for review November 12, 2022 02:27
* "The packages perl ..."
* punctuation
* avoid contraction (it is, etc.)
This example takes the most complex case: using a static IP. If you have a DHCP server available, the process will be much easier.

This is the most amusing part of the procedure: I'm sure you'll go and admire the VMware console during the generation, just to see the automatic entry of the commands during the boot.
This is the most amusing part of the procedure: i am sure you will go and admire the VMware console during the generation, just to see the automatic entry of the commands during the boot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SergeCroise If you are proposing this change the "i am" should be capitalized "I am". It looks like you are opposed to all contractions in technical writing, and while I'm not opposed to changing this (it probably does make it easier for translators), they are not technically errors. It might be good when you are making these suggestions, to just note that you are changing them to improve the ability of translators to translate or some other reason.

Otherwise this all looks good. Again, I've got no problems with removing the contractions in favor of the actual wording. Fix this capitalization issue and I will merge this. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right,
in fact, this is an informal phrase.

@github-actions
Copy link

Test results for 4b5d64d:

Number of broken URLs: 0

URL,RESULT,FILENAME

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @SergeCroise

@sspencerwire sspencerwire merged commit e6fe5c3 into rocky-linux:main Nov 16, 2022
@SergeCroise SergeCroise deleted the patch-2 branch November 16, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants