-
Notifications
You must be signed in to change notification settings - Fork 367
Update templates-automation-packer-vsphere.md #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
punctuation, spelling (kickstart response file)
punctuation, spelling, grammar
* "The packages perl ..." * punctuation * avoid contraction (it is, etc.)
| This example takes the most complex case: using a static IP. If you have a DHCP server available, the process will be much easier. | ||
|
|
||
| This is the most amusing part of the procedure: I'm sure you'll go and admire the VMware console during the generation, just to see the automatic entry of the commands during the boot. | ||
| This is the most amusing part of the procedure: i am sure you will go and admire the VMware console during the generation, just to see the automatic entry of the commands during the boot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SergeCroise If you are proposing this change the "i am" should be capitalized "I am". It looks like you are opposed to all contractions in technical writing, and while I'm not opposed to changing this (it probably does make it easier for translators), they are not technically errors. It might be good when you are making these suggestions, to just note that you are changing them to improve the ability of translators to translate or some other reason.
Otherwise this all looks good. Again, I've got no problems with removing the contractions in favor of the actual wording. Fix this capitalization issue and I will merge this. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right,
in fact, this is an informal phrase.
avoid contraction (I am)
Test results for 4b5d64d:
|
sspencerwire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @SergeCroise
punctuation,
spelling (kickstart response file)
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)