Skip to content

Conversation

@bertronika
Copy link
Contributor

@bertronika bertronika commented Nov 25, 2022

This pull request removes some left-over text in the LXD book, which breaks formatting on the web page and confuses the reader. I've also added a missing dot on the landing README.md - a minor change that does not warrant a separate request.

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

Text seems to be left over from commit 223814a. Its removal now also
fixes Markdown formatting.
@github-actions
Copy link

Test results for 9292f74:

Number of broken URLs: 0

URL,RESULT,FILENAME

@bertronika bertronika changed the title Lxd correction Remove leftovers in the LXD book Nov 25, 2022
Copy link
Member

@wsoyinka wsoyinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for deletion in 03-lxdinit.md is not clear.

@wsoyinka wsoyinka closed this Nov 27, 2022
@bertronika
Copy link
Contributor Author

This is the current state (https://docs.rockylinux.org/books/lxd_server/03-lxdinit/):
lxdinit-webpage

The "Trust password for new clients:" text should appear only once, after setting the address and port for the snapshot server. It is duplicated after the YAML section, along with the trust password explanation.

Furthermore, the erroneous backticks prevent the sentence "Setting Up User Privileges" appearing as a heading, and break the rendering of everything that follows (code blocks and paragraphs are reversed).

@sspencerwire
Copy link
Contributor

@bertronika Thank you for this PR. The way your explanation was worded, didn't quite convince those reviewing the PR, but I could physically see the problem you were reporting by pulling up the page in a browser. The trust password section duplicated and the code block backticks are in the incorrect order. I'll go ahead and reopen the PR and merge it. We DO definitely appreciate your review and correction!!

@sspencerwire sspencerwire reopened this Nov 27, 2022
@sspencerwire sspencerwire self-requested a review November 27, 2022 19:14
@sspencerwire
Copy link
Contributor

@all-contributors please add @bertronika for content

@allcontributors
Copy link
Contributor

@sspencerwire

I've put up a pull request to add @bertronika! 🎉

@sspencerwire sspencerwire merged commit 1039935 into rocky-linux:main Nov 27, 2022
@bertronika
Copy link
Contributor Author

The way your explanation was worded ...

I've figured that I should have put the screenshot and better explanation in the first post. I'm glad we got it resolved.

@bertronika bertronika deleted the lxd-correction branch November 27, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants