-
Notifications
You must be signed in to change notification settings - Fork 367
Remove leftovers in the LXD book #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Text seems to be left over from commit 223814a. Its removal now also fixes Markdown formatting.
Test results for 9292f74:
|
wsoyinka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason for deletion in 03-lxdinit.md is not clear.
|
This is the current state (https://docs.rockylinux.org/books/lxd_server/03-lxdinit/): The "Trust password for new clients:" text should appear only once, after setting the address and port for the snapshot server. It is duplicated after the YAML section, along with the trust password explanation. Furthermore, the erroneous backticks prevent the sentence "Setting Up User Privileges" appearing as a heading, and break the rendering of everything that follows (code blocks and paragraphs are reversed). |
|
@bertronika Thank you for this PR. The way your explanation was worded, didn't quite convince those reviewing the PR, but I could physically see the problem you were reporting by pulling up the page in a browser. The trust password section duplicated and the code block backticks are in the incorrect order. I'll go ahead and reopen the PR and merge it. We DO definitely appreciate your review and correction!! |
|
@all-contributors please add @bertronika for content |
|
I've put up a pull request to add @bertronika! 🎉 |
I've figured that I should have put the screenshot and better explanation in the first post. I'm glad we got it resolved. |

This pull request removes some left-over text in the LXD book, which breaks formatting on the web page and confuses the reader. I've also added a missing dot on the landing README.md - a minor change that does not warrant a separate request.
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)