Typography#151
Merged
pickjasmine merged 13 commits intomainfrom Jul 7, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Adds some basic typography components to cover the common use cases in the application. They are only dictating the font size and font weight with the exception of
<Text.Caption/>and<Text.Label/>since those are universally colored for consistency. Some pieces of text still need additional classes to help with colors/padding/margin, but those styles are generally isolated to the specific component's file.You can see what the types look like in this pic, as well as what using the component will render as in the DOM. You can override what the element will render to by specifying the
as="elementType"prop. Check out the<LabelWithValue/>component for an example of that.