fix: string-aware trailing-comma removal in JSONC parser #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls The auto_install_extensions feature uses `sed | jq` to parse .vscode/extensions.json, but this file is JSONC (JSON with Comments), not strict JSON. The current parser fails on: - Block comments (/* */) - Trailing commas (common in VS Code-generated files) - URLs inside string values (sed mangles https:// to https:) Replace the sed|jq pipeline with a proper state-machine JSONC parser that runs on the bundled Node.js binary already shipped with both code-server and vscode-web. This eliminates the jq dependency for this feature. Also batch extension installs into a single invocation using repeated --install-extension flags instead of spawning one process per extension. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move trailing-comma handling into the state-machine loop so it never modifies characters inside quoted strings. Adds a regression test for the edge case (though it can't occur in practice since extension IDs are restricted to [a-z0-9-] by vsce's nameRegex). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for running CI in the fork before updating coder/registry#707.
🤖 Generated with Claude Code